Simplify an artifact viewer for 3D models. #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
force-pushed
the
simplify-threejs-viewer
branch
from
20fafda to
5912e3e
Compare
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 55.68% 55.28% -0.40%
==========================================
Files 34 34
Lines 2094 2100 +6
==========================================
- Hits 1166 1161 -5
- Misses 928 939 +11 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c-bata
force-pushed
the
simplify-threejs-viewer
branch
from
5912e3e to
928b6b7
Compare
c-bata
changed the title
c-bata
force-pushed
the
simplify-threejs-viewer
branch
from
928b6b7 to
bb380e2
Compare
c-bata
force-pushed
the
simplify-threejs-viewer
branch
from
bb380e2 to
2086bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Follow-up #552
What does this implement/fix? Explain your changes.
Move some logic for ThreeJsArtifactViewer to
ThreejsArtifactViewer.tsx.