-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce python coverage CI #534
Introduce python coverage CI #534
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage ? 55.87%
=======================================
Files ? 26
Lines ? 1523
Branches ? 0
=======================================
Hits ? 851
Misses ? 672
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyproject.toml
Outdated
optional = [ | ||
"streamlit", | ||
"boto3", | ||
"moto[s3]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moto[s3]
is a mock library for boto3, and is used by unit tests only. How about moving to the test
category?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@c-bata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your pull request.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Introduce python coverage CI based on optuna settings https://github.com/optuna/optuna/blob/master/.github/workflows/coverage.yml