Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce python coverage CI #534

Merged

Conversation

keisuke-umezawa
Copy link
Member

@keisuke-umezawa keisuke-umezawa commented Jul 29, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

Introduce python coverage CI based on optuna settings https://github.com/optuna/optuna/blob/master/.github/workflows/coverage.yml

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3aa313e). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage        ?   55.87%           
=======================================
  Files           ?       26           
  Lines           ?     1523           
  Branches        ?        0           
=======================================
  Hits            ?      851           
  Misses          ?      672           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyproject.toml Outdated
optional = [
"streamlit",
"boto3",
"moto[s3]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moto[s3] is a mock library for boto3, and is used by unit tests only. How about moving to the test category?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@keisuke-umezawa
Copy link
Member Author

@c-bata
Thank you for your review! I followed your review.

@c-bata c-bata self-assigned this Aug 7, 2023
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your pull request.

@c-bata c-bata merged commit 0f4fc37 into optuna:main Aug 9, 2023
@keisuke-umezawa keisuke-umezawa deleted the feature/introduce-python-coverage branch August 9, 2023 09:32
c-bata added a commit to c-bata/optuna-dashboard that referenced this pull request Aug 14, 2023
…troduce-python-coverage"

This reverts commit 0f4fc37, reversing
changes made to a7cf1d8.
@keisuke-umezawa keisuke-umezawa restored the feature/introduce-python-coverage branch August 16, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants