Add constraints for history plot #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
reviewed
Jul 28, 2023
| name: "Infeasible Trial", | ||
| marker: { | ||
| size: markerSize, | ||
| color: "#cccccc", |
There was a problem hiding this comment.
[nit] #cccccc might be a bit too light in Dark mode. What do you think about using #666666 in dark mode instead?
Suggested change
| color: "#cccccc", | |
| color: mode === "dark" ? "#666666" : "#cccccc", |
Then the history plot will be rendered like below:
| name: `Infeasible Trial of ${h.study_name}`, | ||
| marker: { | ||
| size: markerSize, | ||
| color: "#cccccc", |
1 task
|
Updated colors. It's easier to see now. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Support constraint in optimization history plot like #525
What does this implement/fix? Explain your changes.
Both plots for the study alone and comparison plots were made to take into account the constraints.