Fix scaning of public images #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fix pulling of public images. Currently Klar always expects DOCKER_USER to be specified which is not required in this particular case.
hashmap
commented
Jul 6, 2017
| @@ -131,8 +131,8 @@ func NewImage(qname, user, password string, insecureTLS, insecureRegistry bool) | |||
| name = strings.Join(nameParts, "/") | |||
| } | |||
| if tag == "" { | |||
| tag = strings.Join(tagParts, ":") | |||
| } | |||
| tag = strings.Join(tagParts, ":") | |||
There was a problem hiding this comment.
This part is unrelated, blame gofmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fix pulling of public images (#42). Currently, Klar always expects
DOCKER_USER to be specified which is not required in this particular
case.
This behavior is hard to test in unit tests, the integration test is not a part of the project yet. Also we don't have integration tests running as part of PR process, I do it on my machine and use my env file which contains DOCKER_USER. Now I run it twice with different env files. I'll create a separate issue for test & build improvement.