This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
WordPress VIP Compliance #5
Open
bcampeau
wants to merge
20
commits into
optimizely:wordpress-vip
Choose a base branch
from
alleyinteractive:vip-compliance
base: wordpress-vip
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WordPress VIP Compliance #5
bcampeau
wants to merge
20
commits into
optimizely:wordpress-vip
from
alleyinteractive:vip-compliance
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, adding i18n compatibility
…educed inline JS for config.php
Updates from Optimizely
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for you to test and review. Once you sign off that nothing is broken, we can submit the plugin to VIP. Some key highlights of what was done here with helpful links for future maintenance:
add_option
calls that were running on every page view and moved the logic to the config form to set default values.Please let us know if you have any questions and if you run into issues during testing. I would suggest submitting any updates you make via pull requests back to your master branch so we can review them up to the point of VIP submission to ensure everything stays in line with coding standards.
Thanks.