Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10840] chore: prepare for release 4.1.0 #560

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[FSSDK-10840] chore: prepare for release 4.1.0 #560

merged 1 commit into from
Nov 8, 2024

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • UPS batching for decideAll and decideForKeys methods

Test plan

  • All unit tests and FSC should pass

Issues

@muzahidul-opti muzahidul-opti requested a review from a team as a code owner November 8, 2024 13:02
@muzahidul-opti muzahidul-opti requested a review from jaeopt November 8, 2024 14:08
mikechu-optimizely
mikechu-optimizely approved these changes Nov 8, 2024
View reviewed changes
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does the OptimizelySwiftSDK.podspec & Sources/Utils/SDKVersion.swift need to be bumped too? Sorry, I couldn't find our Swift Release run book, so I'm asking with less knowledge here.

@muzahidul-opti
Copy link
Contributor Author

LGTM.

Does the OptimizelySwiftSDK.podspec & Sources/Utils/SDKVersion.swift need to be bumped too? Sorry, I couldn't find our Swift Release run book, so I'm asking with less knowledge here.

Release script will update the podspec version

@muzahidul-opti muzahidul-opti merged commit fc27e77 into master Nov 8, 2024
12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/prepare-4.1.0 branch November 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @mikechu-optimizely