Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bucketing error at traffic allocation boundaries #449

Merged
merged 2 commits into from
Sep 23, 2020
Merged

fix: bucketing error at traffic allocation boundaries #449

merged 2 commits into from
Sep 23, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 23, 2020

Summary

This fixes a bug of bucketing at traffic allocation boundaries

  • EndOfRange should be compared with "less-than" but "less-than-equal" is used.
  • The bucket hashing generates 0 for userID+expID = “211314358930636871818513703488”.
  • When 0 <= 0, the bucketing interprets it as in-bucket by error, so returns a false result.

Test plan

  • Add more test cases to cover this case in unit tests and FSC.

Issues

  • OASIS-7150

@jaeopt jaeopt requested a review from a team as a code owner September 23, 2020 17:04
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 98.138% when pulling 1ccf832 on jae/bucket into d497ebe on master.

@jaeopt jaeopt removed their assignment Sep 23, 2020
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 5aba7fd into master Sep 23, 2020
@jaeopt jaeopt deleted the jae/bucket branch September 23, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely