(feat): easy event tracking. #359
Conversation
| @@ -27,7 +28,7 @@ | |||
|
|
|||
| // --- Visitor Parameters ---- | |||
| NSString * const OPTLYEventParameterKeysSnapshots = @"snapshots"; // nonnull | |||
| NSString * const OPTLYEventParameterKeysVisitorId = @"visitor_id"; // nonnull | |||
| NSString * const OPTLYEventParameterKeysVisitorId = @"visitor_id"; // nonnull @"enrich_decisions" | |||
| @@ -1626,7 +1626,7 @@ - (void)testTrackWithAttributesComplexAudienceMismatch { | |||
|
|
|||
| [self.optimizelyTypedAudience track:@"user_signed_up" userId:@"test_user" attributes:userAttributes]; | |||
| NSString *logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesConversionFailure, @"user_signed_up"]; | |||
| OCMVerify([loggerMock logMessage:logMessage withLevel:OptimizelyLogLevelInfo]); | |||
| //OCMVerify([loggerMock logMessage:logMessage withLevel:OptimizelyLogLevelInfo]); | |||
There was a problem hiding this comment.
This can be removed right?
| @@ -1386,7 +1386,7 @@ - (void)testTrackExcludesUserFromExperimentWithTypedAudiences { | |||
| }]]; | |||
| [optimizely track:eventId userId:userId attributes:attributes]; | |||
| NSString *logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesConversionFailure, eventId]; | |||
| OCMVerify([loggerMock logMessage:logMessage withLevel:OptimizelyLogLevelInfo]); | |||
| //OCMVerify([loggerMock logMessage:logMessage withLevel:OptimizelyLogLevelInfo]); | |||
There was a problem hiding this comment.
This can be removed right?
|
Headers need to be updated. |
thomaszurkan-optimizely
changed the title
There was a problem hiding this comment.
I think you can get rid of https://github.com/optimizely/objective-c-sdk/blob/master/OptimizelySDKCore/OptimizelySDKCore/Optimizely.m#L912-L961 and associated unit tests.
Will wait to get resolution for compatibility tests before we can get this in.
| @@ -1,5 +1,5 @@ | |||
| /**************************************************************************** | |||
| * Copyright 2016,2018, Optimizely, Inc. and contributors * | |||
| * Copyright 2016-2019, Optimizely, Inc. and contributors * | |||
There was a problem hiding this comment.
nit. This should actually be 2016, 2018-2019 based on what it was previously.
There was a problem hiding this comment.
Does that mean we weren't copyrighted in 2017? I will change it, but, seems weird.
There was a problem hiding this comment.
Looks good. Also, @msohailhussain confirmed that tests are fine.
Going to merge this change.
Summary
Event builder change.
One byproduct is we do not filter the event anymore so we do not get a log message if the event is not part of any experiment. We also send the event when it is not part of any experiment which is different behaviour.
Test plan
Added a test that makes sure enhance_decisions is set
Issues