Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added configurable timeouts for fetchSegments and dispatch events ODP calls #494

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat: Added configurable timeouts for fetchSegments and dispatch events ODP calls #494

merged 2 commits into from
Dec 15, 2022

Conversation

zashraf1985
Copy link
Contributor

Summary

Added configurable timeouts for fetchSegments and dispatch events ODP calls. The default timeout is 10s.

Test plan

  • Manually tested thoroughly
  • All test pass

Issues

FSSDK-8689

@zashraf1985 zashraf1985 requested a review from a team as a code owner December 9, 2022 05:48
@zashraf1985 zashraf1985 removed their assignment Dec 9, 2022
jaeopt
jaeopt requested changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be better with unit tests.

@zashraf1985
Copy link
Contributor Author

Looks good! Will be better with unit tests.

Added unit tests

@zashraf1985 zashraf1985 removed their assignment Dec 13, 2022
jaeopt
jaeopt approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit c68a554 into master Dec 15, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/ats-configurable-timeouts branch December 15, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @jaeopt @optimizely-codereview-bot