Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audiences, Attributes and Events implementation #438
Audiences, Attributes and Events implementation #438
Changes from 10 commits
ed55d43
ebf3a7b
a5eb5c9
13c5a96
5b83801
0aa4ad4
4fa26dd
d064f8d
346b458
3c71919
5413845
0c84679
6ff39a4
83c32e1
725e8a7
5f0de11
48a1b42
b1fd2b5
f3b3d25
707a348
1a48ad7
d0bf1c6
dddcedf
4b50774
1da6305
f09fe7a
a8c4aab
7baef32
5df424e
011a6d4
974ea93
272bbe1
ec15d25
5fccddf
ff0e4ad
d382c3d
d63441c
ae7b43c
ed83db4
9830de1
c9d9dca
7613fde
5bbe711
a7766d0
8e737dd
fe32f57
c7a9fcb
52220b7
3146e9d
fc7fab5
4e9c2fa
035cca9
c2efd87
39943ed
3993335
c439a2f
48dda4f
efd1383
20683c7
d5d5383
41e8e2b
a877930
f79f199
04d1fb9
89722b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove all 3 other constructors above and keep this one only? It's not supposed to open to clients, and internal use only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, will remove and retest to make sure nothing gets broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case we are supposed to use it internally, can we set access modifier accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets chat offline on this, just a couple questions.