Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decision metadata enabled fix. #410

Merged
merged 6 commits into from
Nov 18, 2020
Merged

fix: decision metadata enabled fix. #410

merged 6 commits into from
Nov 18, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Nov 13, 2020 •
edited
Loading

Summary

  • IsFeatureEnabled was sending impression before finalizing all checks of feature enabled. Just made it after finalization.

Test plan

  • can't add unit tests.
  • only FSC should be passed.

@coveralls
Copy link

coveralls commented Nov 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1603

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.75%
Totals Coverage Status
Change from base Build 1595: 0.0%
Covered Lines: 4133
Relevant Lines: 4605
💛 - Coveralls

@msohailhussain msohailhussain marked this pull request as ready for review November 18, 2020 18:52
@msohailhussain msohailhussain requested a review from a team as a code owner November 18, 2020 18:52
@jaeopt jaeopt closed this Nov 18, 2020
@jaeopt jaeopt reopened this Nov 18, 2020
jaeopt
jaeopt approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 3b3bb9a into master Nov 18, 2020
@jaeopt jaeopt deleted the sohail/decision_enabled_fix branch November 18, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mnoman09 mnoman09 Awaiting requested review from mnoman09

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msohailhussain @coveralls @jaeopt @mnoman09