Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-level) Adjusting log level on audience evaluation logs #377

Merged
merged 3 commits into from
Jun 4, 2020
Merged

fix(log-level) Adjusting log level on audience evaluation logs #377

merged 3 commits into from
Jun 4, 2020

Conversation

mnoman09
Copy link
Contributor

Summary

  • Updating audience evaluation log level to be debug. The only info level log will be the one corresponding to the result of overall evaluation of an audience.

@mnoman09 mnoman09 requested a review from a team as a code owner May 29, 2020 09:34
@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1400

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.437%
Totals Coverage Status
Change from base Build 1397: 0.0%
Covered Lines: 3937
Relevant Lines: 4402
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit. looks good otherwise.

core-api/src/main/java/com/optimizely/ab/internal/ExperimentUtils.java Outdated Show resolved Hide resolved
@aliabbasrizvi aliabbasrizvi merged commit 3eba4fc into master Jun 4, 2020
@aliabbasrizvi aliabbasrizvi deleted the mnoman/update_log_level branch June 4, 2020 21:41
This was referenced Jul 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
🤖 12 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @coveralls @aliabbasrizvi @optimizely-codereview-bot