Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Credits section in README.md. #204

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Conversation

mikeproeng37
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 10, 2018

Pull Request Test Coverage Report for Build 584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.41%

Totals Coverage Status
Change from base Build 580: 0.0%
Covered Lines: 2347
Relevant Lines: 2625

💛 - Coveralls

Copy link

@spencerwilson-optimizely spencerwilson-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Additional Code" only needs to be third-party prod dependencies (i.e., what code do they pull in that's not first-party when they fetch the SDK from Bintray). I don't know how Java projects are managed, but if these are the prod dependencies (though maybe they're not; I see JUnit there), then only those (and not packages like findBugs) need to be documented.

Does what's here include transitive dependencies too, like dependencies of Jackson, etc.?

Anyway I think what's here is a superset of the direct prod dependencies, so this seems acceptable as-is.

@mikeproeng37
Copy link
Contributor Author

That's a good point, I don't think we need FindBug in there. Let me check with @thomaszurkan-optimizely to see how he did it.

@mikeproeng37 mikeproeng37 merged commit 1c63a01 into master Aug 22, 2018
@mikeproeng37 mikeproeng37 deleted the mng/include-credits branch September 21, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants