-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-8955] Refac: Replaced all instances of full stack from code comments and in nuspec except owner. #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mments and in nuspec except owner.
LGTM. |
mikechu-optimizely
requested changes
Mar 10, 2023
Co-authored-by: Russell Loube <[email protected]>
optimizely-codereview-bot
requested review from
mikechu-optimizely and
russell-loube-optimizely
March 10, 2023 22:03
jaeopt
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikechu-optimizely
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀✅2️⃣🤓
mnoman09
added a commit
that referenced
this pull request
Mar 14, 2023
…mments and in nuspec except owner. (#332)
mikechu-optimizely
pushed a commit
that referenced
this pull request
Mar 15, 2023
…mments and in nuspec except owner. (#332) * [FSSDK-8955] Refac: Replaced all instances of full stack from code comments and in nuspec except owner. * Update OptimizelySDK.Package/OptimizelySDK.nuspec Co-authored-by: Russell Loube <[email protected]> --------- Co-authored-by: Russell Loube <[email protected]> (cherry picked from commit d2c788e)
mnoman09
added a commit
that referenced
this pull request
Mar 16, 2023
* chore : updated prefix of ticket-check action (#314) (cherry picked from commit 678c6fd) * chore: Fix and Reconfigure GitHub Actions (#319) * Fix <return> method doc for IsFeatureEnabled (#329) * [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version (#330) * [FSSDK-8955] Refac: Replaced all instances of full stack except from changelog file and code files (#331) * Replaced all instances of full stack except from changelog file and code files Co-authored-by: Griffin Cox <[email protected]> * [FSSDK-8955] Do not lint markdown for now * [FSSDK-8955] Remove VALIDATE_MARKDOWN --------- Co-authored-by: mnoman09 <[email protected]> Co-authored-by: Griffin Cox <[email protected]> Co-authored-by: Mike Chu <[email protected]> (cherry picked from commit 5f16357) (cherry picked from commit 887166e) * [FSSDK-8955] Refac: Replaced all instances of full stack from code comments and in nuspec except owner. (#332) (cherry picked from commit 2a5b19c) * [FSSDK-8955] chore: prepare for release 3.11.2 (#333) * [FSSDK-8955] chore: prepare for release 3.11.2 * Nit fixed --------- Co-authored-by: mnoman09 <[email protected]> (cherry picked from commit e620c08) * updated release date to 16th March --------- Co-authored-by: Muhammad Shaharyar <[email protected]> Co-authored-by: Mike Chu <[email protected]> Co-authored-by: mnoman09 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All tests should pass.
Issues