Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8955] Refac: Replaced all instances of full stack from code comments and in nuspec except owner. #332

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Replaced all instances of full stack from code comments and in nuspec except owner.
  • This PR does not contain changes in md files.

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner March 10, 2023 17:28
@mnoman09 mnoman09 removed their assignment Mar 10, 2023
@griffincox-optimizely
Copy link
Contributor

LGTM.

@mikechu-optimizely
Copy link
Contributor

@mnoman09 Should we combine with #331 so we have 1 squashed commit to cherry pick?

@mnoman09
Copy link
Contributor Author

@mnoman09 Should we combine with #331 so we have 1 squashed commit to cherry pick?

No merge them separately, so that when we cherry pick it would be easier.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀✅2️⃣🤓

@mnoman09 mnoman09 merged commit d2c788e into master Mar 14, 2023
@mnoman09 mnoman09 deleted the mnoman/codeCommentUpdate branch March 14, 2023 20:21
mnoman09 added a commit that referenced this pull request Mar 14, 2023
mikechu-optimizely pushed a commit that referenced this pull request Mar 15, 2023
…mments and in nuspec except owner. (#332)

* [FSSDK-8955] Refac: Replaced all instances of full stack  from code comments and in nuspec except owner.

* Update OptimizelySDK.Package/OptimizelySDK.nuspec

Co-authored-by: Russell Loube <[email protected]>

---------

Co-authored-by: Russell Loube <[email protected]>

(cherry picked from commit d2c788e)
mnoman09 added a commit that referenced this pull request Mar 16, 2023
…mments and in nuspec except owner. (#332)

(cherry picked from commit 2a5b19c)
mnoman09 added a commit that referenced this pull request Mar 16, 2023
* chore : updated prefix of ticket-check action (#314)

(cherry picked from commit 678c6fd)

* chore: Fix and Reconfigure GitHub Actions (#319)

* Fix <return> method doc for IsFeatureEnabled (#329)

* [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version (#330)

* [FSSDK-8955] Refac: Replaced all instances of full stack except from changelog file and code files (#331)

* Replaced all instances of full stack except from changelog file and code files

Co-authored-by: Griffin Cox <[email protected]>

* [FSSDK-8955] Do not lint markdown for now

* [FSSDK-8955] Remove VALIDATE_MARKDOWN

---------

Co-authored-by: mnoman09 <[email protected]>
Co-authored-by: Griffin Cox <[email protected]>
Co-authored-by: Mike Chu <[email protected]>
(cherry picked from commit 5f16357)
(cherry picked from commit 887166e)

* [FSSDK-8955] Refac: Replaced all instances of full stack  from code comments and in nuspec except owner. (#332)

(cherry picked from commit 2a5b19c)

* [FSSDK-8955] chore: prepare for release 3.11.2 (#333)

* [FSSDK-8955] chore: prepare for release 3.11.2

* Nit fixed

---------

Co-authored-by: mnoman09 <[email protected]>
(cherry picked from commit e620c08)

* updated release date to 16th March

---------

Co-authored-by: Muhammad Shaharyar <[email protected]>
Co-authored-by: Mike Chu <[email protected]>
Co-authored-by: mnoman09 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants