Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ODP REST API for Sending ODP Events #315

Merged
merged 14 commits into from
Oct 25, 2022
Merged

feat: ODP REST API for Sending ODP Events #315

merged 14 commits into from
Oct 25, 2022

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

Adding module to provide an internal service for sending events to ODP's REST API.

Test plan

  • Added new unit tests to .spec
  • All Existing Unit tests pass.
  • All existing full-stack compatibility tests pass.

Issues

  • FSSDK-8449

@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner October 10, 2022 18:24
@mikechu-optimizely
Copy link
Contributor Author

@msohailhussain Let me know if you want to pair up over this review.

@msohailhussain msohailhussain requested a review from jaeopt October 13, 2022 21:49
msohailhussain
msohailhussain suggested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not reviewed unit test. partial review to unblock if need to work on the feedback.

OptimizelySDK/Odp/Entity/OdpEvent.cs Show resolved Hide resolved
OptimizelySDK/Odp/Entity/OdpEvent.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/GraphQLManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/GraphQLManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/GraphQLManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/RestApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/RestApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/RestApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/RestApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK.Tests/OdpTests/HttpClientTestUtil.cs Show resolved Hide resolved
jaeopt
jaeopt requested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few changes suggested.

OptimizelySDK/Odp/GraphQLManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/GraphQLManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/RestApiManager.cs Outdated Show resolved Hide resolved
jaeopt
jaeopt requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A clarification regarding TLS.

OptimizelySDK/Odp/OdpEventApiManager.cs Outdated Show resolved Hide resolved
jaeopt
jaeopt approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely
Copy link
Contributor Author

LGTM

Thanks @jaeopt . Holding for @msohailhussain 's approval 😉

msohailhussain
msohailhussain suggested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address few more questions.

OptimizelySDK/Odp/OdpEventApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
OptimizelySDK/Odp/OdpSegmentApiManager.cs Outdated Show resolved Hide resolved
@msohailhussain
Copy link
Contributor

@mikechu-optimizely Overall your PR looks good, please address 4 more questions and then lgtm.

@msohailhussain
Copy link
Contributor

last but not least please fix Lint issues.

@mikechu-optimizely
Copy link
Contributor Author

mikechu-optimizely commented Oct 25, 2022 •
edited
Loading

last but not least please fix Lint issues.

It seems like the lint error here in the GitHub Action is about a missing auth token.

Would you like me to pause the Pull Request and resolve this step, so we can make the "Csharp CI with .NET / Lint Code Base (pull_request)" required?

...or are there lint issues that I missed in the code? Can you direct me to an example file?

@msohailhussain
Copy link
Contributor

this is fine for me, we should resolve token issue in future.

msohailhussain
msohailhussain approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mikechu-optimizely mikechu-optimizely merged commit 026d08f into master Oct 25, 2022
@mikechu-optimizely mikechu-optimizely deleted the mike/odp-rest-api branch October 25, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikechu-optimizely @msohailhussain @jaeopt