Refact: Refactored Forced decision #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs and other minor issue due to which tests were failing
# Conflicts: # OptimizelySDK/Config/DatafileProjectConfig.cs # OptimizelySDK/Event/Builder/EventBuilder.cs
| } | ||
|
|
||
| public OptimizelyUserContext(Optimizely optimizely, string userId, UserAttributes userAttributes, Dictionary<string, OptimizelyForcedDecision> forcedDecisions, IErrorHandler errorHandler, ILogger logger) | ||
| public OptimizelyUserContext(Optimizely optimizely, string userId, UserAttributes userAttributes, ForcedDecisionsStore forcedDecisionsStore, IErrorHandler errorHandler, ILogger logger) |
There was a problem hiding this comment.
Do we really need this constructor method? @jaeopt a question for you.
jaeopt
requested changes
Dec 1, 2021
Comment on lines
54
to
+57
| Logger = logger; | ||
| Optimizely = optimizely; | ||
| Attributes = userAttributes ?? new UserAttributes(); | ||
| ForcedDecisionsMap = forcedDecisions ?? new Dictionary<string, OptimizelyForcedDecision>(); | ||
| ForcedDecisionsStore = forcedDecisionsStore ?? new ForcedDecisionsStore(); |
There was a problem hiding this comment.
We need make a copy of forcedDecisionsStore (just like "attributes" copy) since they can be changed after user context copied.
There was a problem hiding this comment.
Also consider optimization as well - most user contexts do not use ForcedDecision, so we can avoid instantiating/copying FDStore when not used at all.
java-sdk impl as a reference https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/OptimizelyUserContext.java
|
LGTM, appreciate the changes |
jaeopt
approved these changes
Dec 2, 2021
| { | ||
| copiedForcedDecisionsStore = ForcedDecisionsStore.NullForcedDecision(); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All FSC and unit tests should pass
Issues