-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ForcedDecisions): add forced-decisions APIs to OptimizelyUserContext #285
Merged
Merged
Changes from 23 commits
Commits
Show all changes
132 commits
Select commit
Hold shift + click to select a range
e9f3ad3
Updated with new asserts. Created function to make map.
MiracleManS 482628c
Updated assertions, changed a few tests
dustin-sier 97acb39
updated decision service tests to be easier to discover issues.
dustin-sier c097e89
Test update
dustin-sier d23fcd0
Updated Usercontext tests
dustin-sier 3abb3e5
Corrected a few missing tests/functionality
dustin-sier dd50814
Added more functionality
dustin-sier 973f24d
Added remove all tests
dustin-sier 4747186
space removed
dustin-sier 3b3070c
cleaned up test/fixed test
dustin-sier 68d918e
Added additional assertions to help with config test
dustin-sier 30a808b
Fixed error
dustin-sier 14a7288
Additional asserts
dustin-sier 8c289b6
finished optimizely config assertions
dustin-sier 6917f4d
Updating decision service
dustin-sier 9723d7a
changed tests to use user context correctly
dustin-sier 86a099b
spacing issues
dustin-sier d5583d7
Additional changes to try and have a working ctor
dustin-sier b7b8fb7
Fixes for test issues
dustin-sier a46516e
Updated comments and removed unused function
dustin-sier b62c547
Renamed arguments
dustin-sier 7df6dd0
Additional updates
dustin-sier d1e8e68
Removed unnecessary config info
dustin-sier 965c6bf
removed commented out code
dustin-sier 63e86b7
added new lines to end of file
dustin-sier 44229f0
updates from feedback
dustin-sier 99c1769
Updates for tests, still failing/WIP
dustin-sier 77626e0
Updated test for new way of handling flagmap
dustin-sier 5287e54
Added null check and added test, removed unnecessary check for null i…
dustin-sier 147773e
Updated comments
dustin-sier d418ea2
Changed to warn, since its not technically an error
dustin-sier 13ca784
Refactored to be clearer where the issues can crop up
dustin-sier aefdf34
Another null check.
dustin-sier 58d40bf
Added tests for unused publics
dustin-sier 484dc21
Updated optimizely to correctly use the right object
dustin-sier 7d420c4
Added copyright
dustin-sier e89f4a0
Updated tests, removed unnecessary call
dustin-sier ac5fd97
removed redundant calls
dustin-sier 7570f48
const update
dustin-sier a01050b
Changed to IsValid for areas that make sense.
dustin-sier 9efc42a
More IsValid changes
dustin-sier 9da8ee5
Unintended up date.
dustin-sier 4783824
Additional changes for str.format
dustin-sier 8fa3198
Removed second collection for no rule key
dustin-sier 5eb9922
WIP replacement for having two collections
dustin-sier 0381512
Removed redundant assignment
dustin-sier 874157e
Updated with single collection
dustin-sier f3ec5fb
Prepend with Test to new test method names
dustin-sier a139aa9
Added documentation
dustin-sier ba19e30
added lock to set/get
dustin-sier 9e4409d
added to copy
dustin-sier 044ad4a
rename failure
dustin-sier a073b79
update to pass unit tests correctly
dustin-sier a401aa9
updated tests
dustin-sier 1106c44
refactored a bit to start
dustin-sier 692ee26
added copyright language
dustin-sier cbbe452
changed error messages to be consistent
dustin-sier 19eb3da
Updated additional project files
dustin-sier e72faee
Added checks for GetDecisionKey in tests
dustin-sier 97b52a9
Added test for additional logging info
dustin-sier 7b76612
Added additional config check
dustin-sier 5288bb1
Removed unnecessary code
dustin-sier 4323773
Fix for null experiment in decide all
dustin-sier 86f8ea5
fix rule key being non-null
dustin-sier 8240f6e
Corrected copying hte files instead of referencing them in the proj.
dustin-sier 82a8d93
A few changes to help with deciding
dustin-sier 87a1fc3
Corrected incorrect nulls
dustin-sier af39695
another update. Missed variation vs flag
dustin-sier 2500dd7
additional fsc things
dustin-sier 8b32b39
Added additional property
dustinsier b209680
Removed file
dustinsier 758f5d0
Fixed project issues
dustinsier 01a90ca
Updated to account for correct null rulekey
dustinsier 7ea219e
Update for handling null rule key correctly
dustinsier 9e17cd8
Updated message
dustinsier 03002e2
Updated message again
dustinsier f4e348b
Fixed not checking for _just_ null on flagkey because empty is fine.
dustin-sier a061f72
fixed refactor after changes to forced decision
dustin-sier 4427c9f
fixed unit tests
dustin-sier 0838c14
merge
dustin-sier 6793b0b
additonal cleanup after refactor
dustin-sier 0211a2d
Updates to try and clean this up to handle nulls correctly across the…
dustin-sier 5ff593e
Removed unnecessary tests
dustin-sier 8ef2a93
Removed redundant test
dustin-sier 85ca51d
Changed to return nullresult iinstead of null, like other places
dustin-sier 5edcc18
updated test
dustin-sier a18f774
removed unneded list
dustin-sier c9db119
check for null on eventbuilder
dustin-sier c9acbdb
Removed unnecessary piece of test
dustin-sier 964bba5
Added assertion to help with local FSC testing. Fixed logic in decisi…
dustin-sier d78a22b
Fixed content of message
dustin-sier 3bd0991
Removed conditional toReport
dustin-sier b685bbd
removed local fsc test help
dustin-sier 87fe232
Added reasons being returned
dustin-sier 059fafd
Added a "true" for now
dustin-sier 80abfa3
Added period to match string
dustin-sier 9c87d71
cleaned up decision key
dustin-sier f0f8ee8
Updated message and tests for forced decision via experiment
dustin-sier 9afc59a
Fixed key comparison test
dustin-sier e4c190c
Added missing chunk from decision service
dustin-sier 07b69f2
decision service cleanup and tests
dustin-sier 9e427fa
cleanup
dustin-sier 1a3aab3
Added fixed of forced decisions
mnoman09 3bd0bb0
fixed decision service
mnoman09 ba225f9
test fixed
mnoman09 6f563bb
Fixed Group experiments were not added in experiment id list
mnoman09 c7312ec
updated git ignore, included additiona assertions
dustin-sier 0db66fd
rename variationKey to include _
dustin-sier 8bce727
Removed partial that...shouldn't have been in there
dustin-sier 69a2f51
removed unnecessary usings
dustin-sier 10eaf22
Renamed file
dustin-sier f608a70
changed to string.empty
dustin-sier d5c621b
Update to remove null error
dustin-sier 5511a91
change to just experiement?.layerid
dustin-sier 375d748
changed to experiment?.id
dustin-sier 5be1a05
additional change
dustin-sier 48b15ef
rename
dustin-sier 4bca717
changedto string.empty
dustin-sier 0b669eb
Updated to handle null
dustin-sier 6478ed6
copyright fix
dustin-sier d359a0f
Refact: Refactored Forced decision (#287)
mnoman09 cdf53de
fix(ForcedDecision): remove config-ready check from forced-decision a…
mnoman09 b6170cd
some issues fixed.
msohailhussain 0d46ef7
Fixed null experiment check
mnoman09 de95a2c
Null exception fixed
mnoman09 0063e26
Cleanup from pr comments
dustin-sier 2fc7a47
merge
dustin-sier 85b00ff
added reason
dustin-sier 0dccc30
added elvis operator
dustin-sier a829f60
cleaned up ternary
dustin-sier e43898f
fixed eventValue typo
mnoman09 0ac3dbe
trying to force a build
dustin-sier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider to remove this from OptimizelyConfig.