Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): make protected method public #301

Merged
merged 1 commit into from
Aug 29, 2019
Merged

(fix): make protected method public #301

merged 1 commit into from
Aug 29, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Aug 27, 2019 •
edited
Loading

Summary

  • Some developers want to initialize with their datafile and not attempt a background update. The android documentation does not mention background update of cache. By making this method public, we can fix a github issue as well as make the flow diagram correct since one time background updates to cache will be optional. (this does not affect periodic downloads).

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner August 27, 2019 22:52
mikeproeng37
mikeproeng37 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit ca727e0 into master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaszurkan-optimizely @mikeproeng37