add filter, deprecate unsafeSelect #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Optional.filter
andfilter
method on all Optics and ApplyOptics.filter
allows to select the targets which satisfy a predicate, for example:filter
can break the fusion law that says thatmodify(f).modify(g) == modify(f andThen g)
, for example:In
bothSteps
, the first value is-4 = (1 - 3) * 2
but insecondStep
it is-2 = (1 - 3)
.The second update
_ * 2
wasn't applied because the target became negative after the first update_ - 3
.In other words,
filter
breaks the property ifreplace
ormodify
invalidate the predicate.A safe usage would be to filter on one field and update another one, for example: