Port tests to munit #943
Merged
Port tests to munit #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <[email protected]>
|
Looks great. I didn't see any test disabled. |
| @@ -20,7 +20,7 @@ class StringsSpec extends MonocleSuite { | |||
| checkAll("String to Int", PrismTests(stringToInt)) | |||
| checkAll("String to Long", PrismTests(stringToLong)) | |||
| checkAll("String to UUID", PrismTests(stringToUUID)) | |||
| checkAll("String to URI", PrismTests(stringToURI)) | |||
| // checkAll("String to URI", PrismTests(stringToURI)) | |||
| } | ||
|
|
||
| test("monocle.std.all._ brings all polymorphic Optic instances in scope for standard Scala classes") { | ||
| import monocle.function.all._ | ||
|
|
||
| // do not compile because Head instance for HList is not in scope | ||
| illTyped("""head[Int :: HNil, Int].modify(1 :: HNil, _ + 1) shouldEqual (2 :: HNil)""") | ||
| illTyped("""assertEquals(head[Int :: HNil, Int].modify(1 :: HNil, _ + 1), (2 :: HNil))""") |
There was a problem hiding this comment.
On a second pass, we may want to use compileErrors from munit instead of illTyped
|
I propose that we merge it and a few tickets to tackle the commented tests. WDYT? |
julien-truffaut
approved these changes
Nov 11, 2020
|
Sounds good, I think munit will make it easier to support dotty |
Definitely! |
cquiroz
commented
Nov 11, 2020
| } | ||
|
|
||
| test("GenIso nullary equality") { | ||
| GenIso.unit[Nullary] shouldEqual _nullary | ||
| test("GenIso nullary equality".ignore) { |
There was a problem hiding this comment.
These are not working anymore, but TBH I don't know how could that have worked in the past
| @@ -20,7 +20,7 @@ class StringsSpec extends MonocleSuite { | |||
| checkAll("String to Int", PrismTests(stringToInt)) | |||
| checkAll("String to Long", PrismTests(stringToLong)) | |||
| checkAll("String to UUID", PrismTests(stringToUUID)) | |||
| checkAll("String to URI", PrismTests(stringToURI)) | |||
| // checkAll("String to URI", PrismTests(stringToURI)) | |||
There was a problem hiding this comment.
This one is odd. I think it is related to changes on Scalia check but I can't pinpoint the reason. Enabling it triggers an error during the generation of URIs
This was referenced Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports all tests to munit. I had to disable a few tests that I'll point in the comments.
This also upgrades discipline-core