Add POptionals into Ior's left and right #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +20,16 @@ trait TheseOptics { | |||
| case Right(b) => That(b) | |||
| } | |||
|
|
|||
| def theseLeft[A, B, C]: POptional[Ior[A, B], Ior[C, B], A, C] = | |||
There was a problem hiding this comment.
would you mind to rename those pTheseLeft and pTheseRight and create monophormic aliases e.g. theseLeft[A, B] = pTheseLeft[A, B, A]?
This is because monomoprhic optics have better type inference.
theseLeft[A, B, C]: POptional[Ior[A, B], Ior[C, B], A, C] and theseRight[A, B, C]: POptional[Ior[A, B], Ior[A, C], B, C] can look into the left and right parts of an Ior and modify any present value.
chwthewke
force-pushed
the
ior-optionals
branch
from
4580456 to
55dd6de
Compare
|
Awesome, great work @chwthewke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This proposal is to add
theseLeft[A, B, C]: POptional[Ior[A, B], Ior[C, B], A, C]and
theseRight[A, B, C]: POptional[Ior[A, B], Ior[A, C], B, C]which can look into the left and right parts of an Ior and modify the value if present.
TheseSpecwas amended with the appropriate law checks, and I've run the (jvm) tests successfully.Is this of any interest?
Thanks