Add Iso involuton #869
Merged
Add Iso involuton #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,6 +336,13 @@ object Iso { | |||
| /** alias for [[PIso]] id when S = T and A = B */ | |||
| def id[S]: Iso[S, S] = | |||
| PIso.id[S, S] | |||
|
|
|||
| /** | |||
| * create a [[PIso]] where S = T and A = B from | |||
There was a problem hiding this comment.
I don't think we need the first line of comment.
There was a problem hiding this comment.
As in, is create a [[PIso]] where S = T and A = B redundant? I guess we could change the whole comment block to
/** create a [[Iso]] from a function that is its own inverse */
There was a problem hiding this comment.
yep perfect. Maybe an [[ISO]]
|
Thanks @mlrv LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a quick stab at #868
I wasn't entirely sure whether
involuted(I decided to pick that as opposed toinvolutionto be consistent with haskell) should live on theIsoobject or somewhere else, happy to change it if we think it's better placed elsewhere.