Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate all composeX methods in favor of andThen #1000

Merged
merged 1 commit into from
Dec 23, 2020
Merged

deprecate all composeX methods in favor of andThen #1000

merged 1 commit into from
Dec 23, 2020

Conversation

julien-truffaut
Copy link
Member

No description provided.

cquiroz
cquiroz approved these changes Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I should prepare my sed and vim skills to regex replace my uses of compose 😀

@julien-truffaut
Copy link
Member Author

LGTM
I should prepare my sed and vim skills to regex replace my uses of compose 😀

Indeed, but I think we need to start looking at scalafix to ease up the migration

@julien-truffaut julien-truffaut merged commit 6339fe4 into master Dec 23, 2020
@julien-truffaut julien-truffaut deleted the deprecate-composeX branch December 23, 2020 15:15
@cquiroz
Copy link
Collaborator

cquiroz commented Dec 23, 2020

Yeah a scalafix would be great for 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

@yilinwei yilinwei Awaiting requested review from yilinwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-truffaut @cquiroz