Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤐 Compression / décompression LZMA avec mot de passe #1

Closed
4 of 5 tasks
Dougniel opened this issue Nov 8, 2022 · 14 comments
Closed
4 of 5 tasks

🤐 Compression / décompression LZMA avec mot de passe #1

Dougniel opened this issue Nov 8, 2022 · 14 comments
Assignees
@Dougniel
Labels
BUILD Toute activité liée à la création de nouvelles fonctionnalités good first issue Good for newcomers

Comments

@Dougniel
Copy link
Member

Dougniel commented Nov 8, 2022 •
edited
Loading

Requirements

-☝️ Command line tool

  • 🧰 Similar to p7zip

Actions

  • mplement compress/decompress
  • decompress encrypted with password
  • hack compress encrypted with password (as it not supported by Apache Commons Compress) 👉🏼 this branch
  • Make a PR on Apache Commons Compress project - and wait (COMPRESS-633)
  • Get the last version of Apache Commons Compress with the feature 🎉
@Dougniel Dougniel added BUILD Toute activité liée à la création de nouvelles fonctionnalités good first issue Good for newcomers labels Nov 8, 2022
@Dougniel Dougniel self-assigned this Nov 8, 2022
@Dougniel Dougniel changed the title 🤐 Implémentation compression / décompression LZMA avec mot de passe 🤐 Compression / décompression LZMA avec mot de passe Nov 8, 2022
Dougniel added a commit that referenced this issue Nov 8, 2022
@Dougniel
feat(LZMA): 🤐 Compression / décompression LZMA
7aecc37 
- utilisation de Apache Commons Compres & xz
- support du mot de passe
- reprise de l'interface de `p7zip`

WIP #1
Dougniel added a commit that referenced this issue Nov 8, 2022
@Dougniel
ci(semantic-release): GH Token missing
444e3b6 
WIP #1
Dougniel added a commit that referenced this issue Nov 9, 2022
@Dougniel
feat(LZMA): ☝️ alignement sur l'interface de 7z
52ef0aa 
+ tests 🧪

WIP #1
Dougniel added a commit that referenced this issue Nov 9, 2022
@Dougniel
test(LZMA): 🧪 bug dans le test
d787303 
WIP #1
Dougniel added a commit that referenced this issue Nov 25, 2022
@Dougniel
test(ci): Mise en place de la couverture de test
ed5254f 
WIP #1
Dougniel added a commit that referenced this issue Nov 25, 2022
@Dougniel
feat(encrypt): hack compress encrypted with password
28e8666 
..as it not supported by Apache Commons Compress

Next step, PR to Apache Commons Compress project

#1
Dougniel added a commit that referenced this issue Nov 25, 2022
@Dougniel
feat(encrypt): hack compress encrypted with password
8d802bd 
..as it not supported by Apache Commons Compress

Next step, PR to Apache Commons Compress project

#1
Dougniel added a commit that referenced this issue Nov 25, 2022
@Dougniel
feat(encrypt): hack compress encrypted with password
4b8c3e3 
..as it not supported by Apache Commons Compress

Next step, PR to Apache Commons Compress project

#1
@Dougniel
Copy link
Member Author

Dougniel commented Nov 28, 2022 •
edited
Loading

🤞🏼PR prête sur le GitHub mirror de Apache Commons Compress + ticket JIRA

@adriens
Copy link
Member

adriens commented Nov 28, 2022

@Dougniel , petite typo : Encyrption -> Encryption 😅

@adriens adriens pinned this issue Nov 28, 2022
@Dougniel
Copy link
Member Author

🤔
image

@Dougniel
Copy link
Member Author

Dougniel commented Nov 29, 2022 •
edited
Loading

👉🏼 apache/commons-compress#332 (comment)

⏸️ Waiting for CI results

@adriens
Copy link
Member

adriens commented Nov 29, 2022

Classe 😎
image

Dougniel added a commit that referenced this issue Nov 29, 2022
@Dougniel
feat(encrypt): padding corrption
ed60a16 
When the size of file is < cipher block size (16 bytes)

#1
@Dougniel
Copy link
Member Author

PR Mergée 🎉

⏸️ En attente de release

@adriens
Copy link
Member

adriens commented Dec 11, 2022

OH ❣️ 💪 🚀 👏 👏

@adriens
Copy link
Member

adriens commented Dec 11, 2022

Excellent !!!! Bravo @Dougniel 🏋️‍♂️

@Dougniel
Copy link
Member Author

image

Tu as été relancé sur le sujet @adriens ? Je crois qu'il va peut-être falloir livrer non ?

@adriens
Copy link
Member

adriens commented Dec 20, 2022

Non, pas été relancé car pu rl'instant on a un contournement.
Mais on pourrait livrer en attendant et attaqer la partie delivery continue/packaging avec JReelaser.

Une fois la PR mergée, ce sera "une nouvelle release" : qu'en dis-tu ?

@Dougniel
Copy link
Member Author

Non, pas été relancé car pu rl'instant on a un contournement. Mais on pourrait livrer en attendant et attaqer la partie delivery continue/packaging avec JReelaser.

Une fois la PR mergée, ce sera "une nouvelle release" : qu'en dis-tu ?

Oui on peut faire ça, ce sera transparent pour les utilisateurs

@adriens
Copy link
Member

adriens commented Dec 20, 2022

Yep, tout à fait 🚀

@adriens
Copy link
Member

adriens commented Dec 20, 2022

Surtotu qu'il y a pas mal de boulot côté CI et packaging

Dougniel added a commit that referenced this issue Dec 21, 2022
@Dougniel
fix: update with lastest changes from common-compress`
a00b4b9 
#1
@Dougniel
Copy link
Member Author

Première version releasée

@adriens adriens unpinned this issue Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dougniel Dougniel

Labels
BUILD Toute activité liée à la création de nouvelles fonctionnalités good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adriens @Dougniel