Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom connection labels #207

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

duksis
Copy link
Contributor

@duksis duksis commented May 25, 2024

Adds the possibility to configure custom labels to be added to the worker processes.

This can be done by adding labels keys to the connection config

def start(_, _) do
  children = [
    {FaktoryWorker, connection: [
      host: "localhost",
      password: "very-secret",
      labels: ["dev-machine", "elixir-#{System.version()}"]
    ]}
  ]

  Supervisor.start_link(children,
    strategy: :one_for_one,
    name: FaktoryWorkerUsage.Supervisor
  )
end

Resulting in the additional dev-machine label being displayed on the faktory worker dashboard

Screenshot 2024-05-25 at 17 23 48

closes #191

@Ch4s3
Copy link
Collaborator

Ch4s3 commented Dec 18, 2024

hey @duksis I just saw this. We don't do a ton of maintenance on this library, but I'm going to review this tomorrow and probably roll it into the next release. Thanks for the contribution, and sorry for the delay.

@Ch4s3 Ch4s3 merged commit 3402b43 into opt-elixir:master Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to customise worker process labels and Name (wid)
2 participants