Adjust formatting

lib/faktory_worker/batch.ex

@@ -101,7 +101,7 @@ defmodule FaktoryWorker.Batch do
   @spec new!(Keyword.t()) :: {:ok, bid()} | {:error, any()}
   def new!(opts \\ []) do
     if Sandbox.active?() do
-      {:ok, Sandbox.batch_id}
+      {:ok, Sandbox.batch_id()}
     else
       success = Keyword.get(opts, :on_success)
       complete = Keyword.get(opts, :on_complete)
@@ -118,7 +118,6 @@ defmodule FaktoryWorker.Batch do
 
       opts = Keyword.take(opts, [:faktory_name, :timeout])
       FaktoryWorker.send_command({:batch_new, payload}, opts)
-
     end
   end
 
@@ -163,7 +162,6 @@ defmodule FaktoryWorker.Batch do
     else
       FaktoryWorker.send_command({:batch_status, bid}, opts)
     end
-
   end
 
   defp maybe_put_description(payload, nil), do: payload

lib/faktory_worker/connection_manager.ex

@@ -39,7 +39,7 @@ defmodule FaktoryWorker.ConnectionManager do
         state = %{state | conn: nil}
 
         if allow_retry,
-          do: send_command(%{state | conn: nil}, command, false),
+          do: send_command(state, command, false),
           else: {error, state}
 
       # Handle errors from Faktory that should not be tried again
@@ -87,6 +87,6 @@ defmodule FaktoryWorker.ConnectionManager do
   defp close_connection(%{conn: nil}), do: :ok
 
   defp log_error(reason, {_, %{jid: jid}}) do
-    Logger.warn("[#{jid}] #{reason}")
+    Logger.warning("[#{jid}] #{reason}")
   end
 end

lib/faktory_worker/sandbox.ex

@@ -155,12 +155,13 @@ defmodule FaktoryWorker.Sandbox do
 
   def batch_id, do: "sandbox-batch-id"
 
-  def batch_status, do: %{
-    "bid" => batch_id(),
-    "total" => 10,
-    "pending" => 14,
-    "failed" => 3,
-    "created_at" =>  "2019-11-18T13:48:25Z",
-    "description" => "This is a sandbox status"
-  }
+  def batch_status,
+    do: %{
+      "bid" => batch_id(),
+      "total" => 10,
+      "pending" => 14,
+      "failed" => 3,
+      "created_at" => "2019-11-18T13:48:25Z",
+      "description" => "This is a sandbox status"
+    }
 end

test/faktory_worker/connection/connection_integration_test.exs

@@ -3,8 +3,8 @@ defmodule FaktoryWorker.Connection.ConnectionIntegrationTest do
 
   alias FaktoryWorker.Connection
 
-  @passworded_connection_opts Application.get_env(:faktory_worker, :passworded_server)
-  @tls_connection_opts Application.get_env(:faktory_worker, :tls_server)
+  @passworded_connection_opts Application.compile_env(:faktory_worker, :passworded_server)
+  @tls_connection_opts Application.compile_env(:faktory_worker, :tls_server)
 
   describe "open/1" do
     test "should return a connection to faktory" do

test/faktory_worker/connection/socket/ssl_test.exs

@@ -4,8 +4,8 @@ defmodule FaktoryWorker.Connection.Socket.SslTest do
   alias FaktoryWorker.Connection
   alias FaktoryWorker.Socket.Ssl
 
-  @tls_host Application.get_env(:faktory_worker, :tls_server)[:host]
-  @tls_port Application.get_env(:faktory_worker, :tls_server)[:port]
+  @tls_host Application.compile_env(:faktory_worker, :tls_server)[:host]
+  @tls_port Application.compile_env(:faktory_worker, :tls_server)[:port]
 
   describe "connect/3" do
     test "should open a ssl socket to faktory" do

test/faktory_worker/connection_manager_test.exs

@@ -172,6 +172,8 @@ defmodule FaktoryWorker.ConnectionManagerTest do
         {:ok, "+OK\r\n"}
       end)
 
+      expect(FaktoryWorker.SocketMock, :close, fn _ -> :ok end)
+
       opts = [socket_handler: FaktoryWorker.SocketMock]
 
       state = %ConnectionManager{

test/faktory_worker/error_formatter_test.exs

@@ -6,9 +6,9 @@ defmodule FaktoryWorker.ErrorFormatterTest do
 
   describe "format_error/2" do
     @stacktrace [
-      {TestApp.Worker, :raise_error, 1, [file: 'lib/worker.ex', line: 50]},
-      {TestApp.Worker, :do_work, 1, [file: 'lib/worker.ex', line: 37]},
-      {TestApp.Worker, :perform, 1, [file: 'lib/worker.ex', line: 9]}
+      {TestApp.Worker, :raise_error, 1, [file: ~c"lib/worker.ex", line: 50]},
+      {TestApp.Worker, :do_work, 1, [file: ~c"lib/worker.ex", line: 37]},
+      {TestApp.Worker, :perform, 1, [file: ~c"lib/worker.ex", line: 9]}
     ]
 
     @formatted_stacktrace [

test/faktory_worker/job/job_test.exs

@@ -183,5 +183,4 @@ defmodule FaktoryWorker.Job.JobTest do
       assert error == "The field 'queue' has an invalid value '123'"
     end
   end
-
 end

test/faktory_worker/worker/heartbeat_server_test.exs

@@ -253,6 +253,8 @@ defmodule FaktoryWorker.Worker.HeartbeatServerTest do
         {:error, :econnrefused}
       end)
 
+      expect(FaktoryWorker.SocketMock, :close, fn _ -> :ok end)
+
       opts = [socket_handler: FaktoryWorker.SocketMock, is_worker: true, process_wid: process_wid]
 
       state = %{

test/faktory_worker/worker/server_test.exs

@@ -32,7 +32,7 @@ defmodule FaktoryWorker.Worker.ServerTest do
                id: :test_worker_1,
                start:
                  {FaktoryWorker.Worker.Server, :start_link,
-                 [[name: :test_worker_1, connection: [port: 7000]]]},
+                  [[name: :test_worker_1, connection: [port: 7000]]]},
                type: :worker
              }
     end
@@ -247,6 +247,7 @@ defmodule FaktoryWorker.Worker.ServerTest do
         state
         |> Map.put(:job_id, job_id)
         |> Map.put(:job_ref, %{ref: job_ref})
+        |> Map.put(:job_start, System.monotonic_time(:millisecond))
       end)
 
       Process.send(pid, {job_ref, :ok}, [])
@@ -289,6 +290,7 @@ defmodule FaktoryWorker.Worker.ServerTest do
 
       :sys.replace_state(pid, fn state ->
         state
+        |> Map.put(:job_start, System.monotonic_time(:millisecond))
         |> Map.put(:job_id, job_id)
         |> Map.put(:job, %{"jid" => job_id})
       end)