Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification policy filters ordering #410

Closed

Conversation

gjacquet
Copy link
Contributor

This should address #409.

Conditions and restrictions should be Sets rather than Lists.

@gjacquet
Copy link
Contributor Author

This is basically the same fix as #390

@koushik-swaminathan
Copy link
Contributor

@gjacquet could you refer #390 and make similar changes throughout the file?

@gjacquet
Copy link
Contributor Author

gjacquet commented Oct 25, 2023

@koushik-swaminathan This is what I did but I missed a few spots that I addressed this morning.
I ran a few test on my project and it seems to address my issue.

@koushik-swaminathan
Copy link
Contributor

@gjacquet alright let me test it out and get back to you

@Baarsgaard
Copy link
Contributor

Hi @gjacquet , just an FYI.
When you commit a binary and delete it in a subsequent commit, the binary is still stored in the repository.
You would need to rebase and squash your commits together to properly delete the binary from the initial commit that introduced it.

This should address opsgenie#409.
Conditions and restrictions should be Sets rather than Lists.
@gjacquet gjacquet force-pushed the fix-notification-policy-order branch from 9bc565d to 0066932 Compare October 26, 2023 13:54
@gjacquet
Copy link
Contributor Author

@Baarsgaard Done!
I guess I am more used to the Github squash and merge feature that does all of this as the PR is getting merged.

@koushik-swaminathan
Copy link
Contributor

Hi @gjacquet, another PR has already included these changes along with a few others so I'll be merging that instead. Thank you!

@gjacquet
Copy link
Contributor Author

gjacquet commented Nov 6, 2023

@koushik-swaminathan sounds good!
Out of curiosity, could you please send the link to the other PR addressing this issue? It seems to be #404, is it correct? Do you have an ETA on the next provider release?

@Baarsgaard
Copy link
Contributor

Baarsgaard commented Nov 6, 2023

#404 and I think it's released already! https://registry.terraform.io/providers/opsgenie/opsgenie/0.6.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants