Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return none if request errors, also black #7

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

jacobtomlinson
Copy link
Member

If an API request failed it would never set the response variable but would still try to decode it.

This PR initialises it as None.

Also my editor ran black on the file.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #7 into master will decrease coverage by 0.22%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   42.93%   42.70%   -0.23%     
==========================================
  Files           5        5              
  Lines         191      192       +1     
==========================================
  Hits           82       82              
- Misses        109      110       +1     
Impacted Files Coverage Δ
opsdroid_homeassistant/connector/__init__.py 32.35% <10.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ca541...8643b39. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit 84e4ce0 into master Apr 27, 2020
@jacobtomlinson jacobtomlinson deleted the empty-response branch April 27, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant