Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch websocket handshake exception #10

Conversation

jacobtomlinson
Copy link
Member

It seems that when connecting to the regular websocket url from within a hassio addon it raises a handshake exception.

In #8 supprt was added for the alternate url, this must be why that alternate url exists.

@jacobtomlinson jacobtomlinson added the bug Something isn't working label May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #10 into master will decrease coverage by 0.43%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   42.48%   42.05%   -0.44%     
==========================================
  Files           5        5              
  Lines         193      195       +2     
==========================================
  Hits           82       82              
- Misses        111      113       +2     
Impacted Files Coverage Δ
opsdroid_homeassistant/connector/__init__.py 31.42% <25.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b4472...3483058. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit 65ead3f into opsdroid:master May 4, 2020
@jacobtomlinson jacobtomlinson deleted the catch-websocket-handshake-exception branch May 4, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant