Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for plugins #316

Merged
merged 32 commits into from
Mar 23, 2018
Merged

Add tests for plugins #316

merged 32 commits into from
Mar 23, 2018

Conversation

tamalsaha
Copy link
Contributor

reopen #313

@tamalsaha tamalsaha requested a review from mirshahriar March 23, 2018 15:37
@tamalsaha tamalsaha merged commit c9dfb60 into master Mar 23, 2018
@tamalsaha tamalsaha deleted the client branch March 23, 2018 15:45
tamalsaha pushed a commit that referenced this pull request Mar 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #316 into master will increase coverage by 1.41%.
The diff coverage is 22.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   30.62%   32.04%   +1.41%     
==========================================
  Files           9       14       +5     
  Lines         542      980     +438     
==========================================
+ Hits          166      314     +148     
- Misses        353      613     +260     
- Partials       23       53      +30
Impacted Files Coverage Δ
plugins/check_event/lib.go 0% <0%> (ø)
plugins/notifier/sms.go 0% <0%> (ø) ⬆️
plugins/notifier/incident.go 0% <0%> (ø) ⬆️
plugins/notifier/lib.go 1.43% <1.85%> (+1.43%) ⬆️
plugins/check_component_status/lib.go 44.11% <19.44%> (ø)
plugins/check_json_path/lib.go 37.6% <40.9%> (+8.63%) ⬆️
plugins/check_node_status/lib.go 55.55% <42.85%> (-0.9%) ⬇️
plugins/check_cert/lib.go 61.32% <42.85%> (+0.26%) ⬆️
plugins/check_pod_exists/lib.go 41.66% <44.64%> (ø)
plugins/check_node_exists/lib.go 46.03% <47.82%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20721ae...79ba820. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants