Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure urljoin behaviour is correct #13

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Conversation

davfsa
Copy link
Contributor

@davfsa davfsa commented Jun 15, 2022

Upstream bugfix for mkdocstrings/mkdocstrings#443

I have attempted to write the necessary tests but the layout of the library is interfering a bit:

from mkdocs_gen_files import plugin
Traceback (most recent call last):
  File "/home/davfsa/coding/mkdocs-gen-files/tests/test_plugin.py", line 4, in <module>
    from mkdocs_gen_files import plugin
  File "<frozen importlib._bootstrap>", line 1075, in _handle_fromlist
  File "/home/davfsa/coding/mkdocs-gen-files/mkdocs_gen_files/__init__.py", line 20, in __getattr__
    return getattr(FilesEditor.current(), name)
  File "/home/davfsa/coding/mkdocs-gen-files/mkdocs_gen_files/editor.py", line 94, in current
    config = load_config("mkdocs.yml")
  File "/home/davfsa/coding/mkdocs-gen-files/.venv/lib/python3.10/site-packages/mkdocs/config/base.py", line 236, in load_config
    raise exceptions.Abort(
mkdocs.exceptions.Abort: Aborted with 3 Configuration Errors!

Not sure what the best way to fix this would be

@oprypin
Copy link
Owner

oprypin commented Jun 18, 2022

Thanks!

@oprypin oprypin merged commit 0ff1810 into oprypin:master Jun 18, 2022
@oprypin
Copy link
Owner

oprypin commented Jul 5, 2022

I finally made a release with this. https://github.com/oprypin/mkdocs-gen-files/releases/tag/v0.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants