-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #10: Hifi ContinuePlaying #605
Conversation
…te and applied dimensionRatio to the image.
@Luffy18346 please change the title to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The divider color should be updated to:
#9C000000
the reason behind this is as follows:
The eight character color code in mocks contains first 6 characters as color and last two characters as percentage of transparency. Now the transparency in android takes first two character and also convert 61 to hex is 9C. -
Bottom padding of reyclerview needs to be 172dp as per mocks.
… in ongoing_story_card.
…clerView paddingBottom set to 172dp
@rt4914 , I have looked at the mock and updated the bottom padding of reyclerView to 172dp. |
@Luffy18346 everything looks great, you just need to address two more comments: |
@rt4914, I have not changed the divider color to |
Okay, even I was unsure about this. Sounds good. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Luffy18346
Explanation
Fix part of #10: Removed hardcoded height attribute and applied dimensionRatio of 16:9 to the image keeping a fixed width. So, the height of the image will be set according to the applied dimension ratio.
Checklist