Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning fixes: xml tag has empty body & replace dp with sp in xml files. #594

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Warning fixes: xml tag has empty body & replace dp with sp in xml files. #594

merged 2 commits into from
Jan 7, 2020

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Jan 7, 2020 •
edited
Loading

Explanation

This Pr fixes xml tags that has empty body and replaces dp with sp in xml file.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs changed the title Warning fixes: xml tag has empty body. Warning fixes: xml tag has empty body & replace dp with sp in xml files. Jan 7, 2020
rt4914
rt4914 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rt4914
rt4914 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 merged commit 61de850 into develop Jan 7, 2020
@rt4914 rt4914 deleted the warning-fixes-3 branch January 7, 2020 11:13
nikitamarysolomanpvt
nikitamarysolomanpvt reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt left review comments

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @rt4914 @nikitamarysolomanpvt