Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #568: @Inject related reformatting issues #570

Merged
merged 5 commits into from
Dec 23, 2019

Conversation

Luffy18346
Copy link
Contributor

@Luffy18346 Luffy18346 commented Dec 21, 2019

Explanation

This PR fixes #568 @Inject related reformatting issues. Please look into it, @rt4914.

Issue - Incorrect Format

@Inject
  lateinit var homeActivityPresenter: HomeActivityPresenter 

Correction done -
@Inject lateinit var homeActivityPresenter: HomeActivityPresenter

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 self-assigned this Dec 23, 2019
@rt4914 rt4914 self-requested a review December 23, 2019 05:25
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Dec 23, 2019
@rt4914
Copy link
Contributor

rt4914 commented Dec 23, 2019

@Luffy18346 Normally, after the pull request is approved the author of the pull request in expected to merge that branch in the develop. But if the reviewers feel that the PR can be merged immediately, then even the reviewer can also merge this PR.

In this case, I know that you won't be able to merge this before evening, so I am merging this now.

@rt4914 rt4914 merged commit e0879e4 into oppia:develop Dec 23, 2019
@rt4914 rt4914 mentioned this pull request Jan 3, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Inject related reformatting issues
2 participants