Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflow with HomeActivity changes #5507

Closed
wants to merge 3 commits into from

Conversation

adhiamboperes
Copy link
Collaborator

Explanation

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes adhiamboperes requested review from a team as code owners August 22, 2024 14:27
@adhiamboperes adhiamboperes self-assigned this Aug 22, 2024
@adhiamboperes adhiamboperes deleted the test_coverage_workflow branch August 22, 2024 14:52
Copy link

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 14.99%
Coverage Analysis: FAIL

Failing coverage

File Coverage Lines Hit Status Min Required
ComputeAabDifferences.ktscripts/src/java/org/oppia/android/scripts/apkstats/ComputeAabDifferences.kt
5.46% 19 / 348 6% *

* represents tests with custom overridden pass/fail coverage thresholds

Passing coverage

Files with passing code coverage
File Coverage Lines Hit Status Min Required
GitClient.ktscripts/src/java/org/oppia/android/scripts/common/GitClient.kt
100.00% 39 / 39 70%

Exempted coverage

Files exempted from coverage
File Exemption Reason
HomeActivity.ktapp/src/main/java/org/oppia/android/app/home/HomeActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant