Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Part of #4938: New onboarding flow gating platform param 1 of 3 #5269

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Dec 11, 2023

Explanation

Fix Part of #4938: Introduce a new platform parameter that will be used to gate the revised onboarding flow during development.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes adhiamboperes requested review from a team as code owners December 11, 2023 10:28
@adhiamboperes
Copy link
Collaborator Author

Hi @kkmurerwa, could you please take a look at this PR?

Copy link
Collaborator

@kkmurerwa kkmurerwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes I have taken a look at the PR and have left a few comments. PTAL

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Dec 18, 2023
Copy link

oppiabot bot commented Dec 25, 2023

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 25, 2023
@oppiabot oppiabot bot closed this Jan 1, 2024
@adhiamboperes adhiamboperes reopened this Jan 31, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 31, 2024
@adhiamboperes
Copy link
Collaborator Author

@kkmurerwa, I have addressed your comments. PTAL.

@adhiamboperes adhiamboperes changed the title Fix Part of #4938: New onboarding flow gating platform param Fix Part of #4938: New onboarding flow gating platform param 1 of 3 Jan 31, 2024
@adhiamboperes
Copy link
Collaborator Author

Thanks @kkmurerwa!

@BenHenning, PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhiamboperes! This LGTM.

@BenHenning
Copy link
Member

Deferring to you to merge @adhiamboperes since I'm not sure if you have any branched PRs coming after this that require special handling.

@oppiabot oppiabot bot added the PR: LGTM label Feb 6, 2024
Copy link

oppiabot bot commented Feb 6, 2024

Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 604b609 into develop Feb 7, 2024
40 checks passed
@adhiamboperes adhiamboperes deleted the new-onboarding-platform-param branch February 7, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants