-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4938: New onboarding flow gating platform param 1 of 3 #5269
Conversation
Hi @kkmurerwa, could you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes I have taken a look at the PR and have left a few comments. PTAL
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
Outdated
Show resolved
Hide resolved
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@kkmurerwa, I have addressed your comments. PTAL. |
Thanks @kkmurerwa! @BenHenning, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adhiamboperes! This LGTM.
Deferring to you to merge @adhiamboperes since I'm not sure if you have any branched PRs coming after this that require special handling. |
Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fix Part of #4938: Introduce a new platform parameter that will be used to gate the revised onboarding flow during development.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: