Fix part of #4865 and Fix #4986 : Move all fragment arguments, activity intent extras, and saved instance state over to protos

[Vishwajith-Shettigar]

Explanation

Fixes #4986
Move all fragment arguments, activity extras, and saved instance state bundle usage over to using protos entirely.

Fix part of #4865
Introduce a ProfileID decorator to pack ProfileId into all Intents so that it can be easily accessed by underlying fragments and child classes. Some classes already use this utility where it was not easy to add profileId to the intent proto bundle.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[Vishwajith-Shettigar]

Apologies @Vishwajith-Shettigar will need a few more days before I can follow up on this.

No problem @BenHenning!

[BenHenning]

Thanks @Vishwajith-Shettigar! Apologies for the long delay in reviewing this. I've taken a complete pass, so follow-ups should be quick.

I basically only had nits. There were a few bigger and broader issues I noticed, but decided not to ask for changes here. Specifically:

• There are a bunch of formatting inconsistencies, some of which already existed. This will be fixed when we reformat the whole codebase in the future.
• There is some inconsistency in nullability management, most of which already existed. This is probably something we'll want to tackle completely by itself in the future.
• Defaulting to a default instance of ProfileId is a behavior change over using -1 for the internal profile ID. I think the likelihood of these cases ever happening is near zero with our unit tests, but it brings up the broader problem that default instance of ProfileId generally corresponds to a valid profile in the app (admin) which is a bad situation as it could result in unintentional privilege escalation if a profile ever does get defaulted. I plan to file a separate issue for this as it will require very broad changes to fully address.

That being said, I think after the most recent comments are addressed I'll be happy to approve this. There are a lot of really great clean-ups and simplifications included in this PR, so it would be quite nice to get it wrapped up and merged. :)

Edit: #5440 is the issue now tracking point (3) above (the potential problems with defaulting ProfileId).

[BenHenning]

Also: @Vishwajith-Shettigar please re-assign once all CI checks are passing (in addition to the comments being addressed). The PR can't be merged until those problems are addressed, as well.

[Vishwajith-Shettigar]

Thanks @BenHenning, I addressed your comments, PTAL.

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Thanks @Vishwajith-Shettigar! Just had one follow-up comment--PTAL.

[Vishwajith-Shettigar]

Thanks @BenHenning, PTAL.

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 16 MiB (old), 16 MiB (new), 84 KiB (Added)

APK download size (estimated): 14 MiB (old), 14 MiB (new), 79 KiB (Added)

Method count: 221791 (old), 226445 (new), 4654 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6550 (new), 0 (No change)

• Anim: 49 (old), 49 (new), 0 (No change)
• Animator: 20 (old), 20 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 915 (old), 915 (new), 0 (No change)
• Bool: 10 (old), 10 (new), 0 (No change)
• Color: 911 (old), 911 (new), 0 (No change)
• Dimen: 994 (old), 994 (new), 0 (No change)
• Drawable: 373 (old), 373 (new), 0 (No change)
• Id: 1206 (old), 1206 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 368 (old), 368 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 805 (old), 805 (new), 0 (No change)
• Style: 816 (old), 816 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 15 MiB (old), 15 MiB (new), 84 KiB (Added)
APK download size (estimated): 14 MiB (old), 14 MiB (new), 76 KiB (Added)
Method count: 221791 (old), 226445 (new), 4654 (Added)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 10 MiB (old), 10 MiB (new), 34 KiB (Added)

APK download size (estimated): 9150 KiB (old), 9179 KiB (new), 28 KiB (Added)

Method count: 99436 (old), 101315 (new), 1879 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

• Anim: 39 (old), 39 (new), 0 (No change)
• Animator: 18 (old), 18 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 879 (old), 879 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 767 (old), 767 (new), 0 (No change)
• Dimen: 722 (old), 722 (new), 0 (No change)
• Drawable: 333 (old), 333 (new), 0 (No change)
• Id: 1148 (old), 1148 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 327 (old), 327 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 736 (old), 736 (new), 0 (No change)
• Style: 457 (old), 457 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 34 KiB (Added)
APK download size (estimated): 9030 KiB (old), 9062 KiB (new), 32 KiB (Added)
Method count: 99436 (old), 101315 (new), 1879 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 10 MiB (new), 34 KiB (Added)

APK download size (estimated): 9135 KiB (old), 9165 KiB (new), 29 KiB (Added)

Method count: 99436 (old), 101315 (new), 1879 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

• Anim: 39 (old), 39 (new), 0 (No change)
• Animator: 18 (old), 18 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 879 (old), 879 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 767 (old), 767 (new), 0 (No change)
• Dimen: 722 (old), 722 (new), 0 (No change)
• Drawable: 333 (old), 333 (new), 0 (No change)
• Id: 1148 (old), 1148 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 327 (old), 327 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 736 (old), 736 (new), 0 (No change)
• Style: 457 (old), 457 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 34 KiB (Added)
APK download size (estimated): 9019 KiB (old), 9050 KiB (new), 30 KiB (Added)
Method count: 99436 (old), 101315 (new), 1879 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 10 MiB (new), 34 KiB (Added)

APK download size (estimated): 9136 KiB (old), 9165 KiB (new), 29 KiB (Added)

Method count: 99436 (old), 101315 (new), 1879 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5504 (new), 0 (No change)

• Anim: 39 (old), 39 (new), 0 (No change)
• Animator: 18 (old), 18 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 879 (old), 879 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 767 (old), 767 (new), 0 (No change)
• Dimen: 722 (old), 722 (new), 0 (No change)
• Drawable: 333 (old), 333 (new), 0 (No change)
• Id: 1148 (old), 1148 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 327 (old), 327 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 736 (old), 736 (new), 0 (No change)
• Style: 457 (old), 457 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 34 KiB (Added)
APK download size (estimated): 9020 KiB (old), 9049 KiB (new), 29 KiB (Added)
Method count: 99436 (old), 101315 (new), 1879 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 0 bytes (No change)

[BenHenning]

Thanks @Vishwajith-Shettigar. This LGTM!

[BenHenning]

Going ahead and merging this since it seems that everything has now been addressed and the PR is up-to-date with passing CI checks. Thanks again @Vishwajith-Shettigar!