Fix part of #5195: RestrictedApi. Using a private API #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…daptersTest to avoid restricted API error
|
@adhiamboperes, PTAL |
|
Unassigning @sichchurov since a re-review was requested. @sichchurov, please make sure you have addressed all review comments. Thanks! |
adhiamboperes
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Thanks @sichchurov.
The solution looks good, but it is not correct to say that this attribute is unused. I searched, and found multiple usages. See screenshot:
app/src/main/java/org/oppia/android/app/databinding/AppCompatCheckBoxBindingAdapters.java
Outdated
Show resolved
Hide resolved
|
Unassigning @adhiamboperes since the review is done. |
|
Hi @sichchurov, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
|
@adhiamboperes, PTAL |
|
Unassigning @sichchurov since a re-review was requested. @sichchurov, please make sure you have addressed all review comments. Thanks! |
adhiamboperes
approved these changes
Oct 20, 2023
|
Unassigning @adhiamboperes since they have already approved the PR. |
|
Hi @sichchurov, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Rd4dev
pushed a commit
to Rd4dev/oppia-android
that referenced
this pull request
Oct 31, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix part of oppia#5195: I have modified method setButtonTint to avoid an error due to using a restricted API. This method(bindingAdapter) is not set in any of the layouts. Only test is written for it. So it is safety to modify the test also. If not modify a test - it is failed then. **Lint report before** <img src="https://github.com/oppia/oppia-android/assets/71126152/fe9d691b-1bd0-45e9-9f14-7daa73839069" width="70%" height="70%" alt="callingNewApiBefore"> **Lint report after** <img src="https://github.com/oppia/oppia-android/assets/71126152/5689d095-d4ed-4e60-b431-790037b240c3" width="50%" height="50%" alt="callingNewApiBefore"> <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix part of #5195: I have modified method setButtonTint to avoid an error due to using a restricted API.
This method(bindingAdapter) is not set in any of the layouts. Only test is written for it.
So it is safety to modify the test also. If not modify a test - it is failed then.
Lint report before
Lint report after
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: