Fix #4448: Hide promoted story section for the first time user

[JishnuGoyal]

Explanation

This PR is a part of the GSoC project: Interactive Onboarding Flow which fixes #4448 by hiding the promoted stories section when the user logs in for the first time. A clear CTA is also added as the topics list header. Note that when the user enters the app for the second time (and every time after that), the promoted stories section is displayed as usual.

The hiding of the promoted stories section is achieved by utilizing the work in #4438 <--this PR where a login counter was introduced. Tests are modified to account for the hidden UI elements. New test cases are also added to back the functionality introduced in the PR.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Before:

After:
First login:

Second login:

[oppiabot]

Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[oppiabot]

Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[JishnuGoyal]

@BenHenning PTAL would be possible for you to take an initial pass at this? I'll be adding tests for the functionality in my next commit.

[JishnuGoyal]

please ignore the first 4 commits as they were finally changed after merger with develop re: #4438

[BenHenning]

Thanks @JishnuGoyal! Took a first pass--PTAL.

Also, please make sure to fill in the rest of the PR description (I think you're missing filling out the checklist, and the UI part of the PR description is missing).

[JishnuGoyal]

@BenHenning PTAL

[JishnuGoyal]

PTAL @rt4914

[oppiabot]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

[rt4914]

LGTM for codeowners

[oppiabot]

Unassigning @rt4914 since they have already approved the PR.

[BenHenning]

Thanks @JishnuGoyal! Just had one final comment--PTAL.

[JishnuGoyal]

Yes, this has been resolved and was added to a separate function. DataProviderTestMonitor was used instead of the legacy code, as discussed in the meeting.
PTAL @BenHenning

[oppiabot]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Thanks @JishnuGoyal. This LGTM!