Added FractionInputInteractionViewTest.kt #4242

bhaktideshmukh · 2022-03-10T19:26:30Z

Explanation

Fixes #4135 : Added FractionInputInteractionViewTest.kt

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

rt4914

@anandwana001 Can you please take a lead on this PR? I am not sure why I am getting assigned as the code-owner. (I will update this later on in a separate PR).

Thanks.

rt4914 · 2022-03-14T10:00:43Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+    )
+    activityScenario.onActivity { activity ->
+      val pendingAnswer = activity.fractionInteractionViewModel.getPendingAnswer()
+      Truth.assertThat(pendingAnswer.answer).isInstanceOf(InteractionObject::class.java)


Please prefer direct imports here and everywhere else.
assertThat(pendingAnswer.answer).isInstanceOf(InteractionObject::class.java)

rt4914 · 2022-03-14T10:01:01Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+    val activityScenario = ActivityScenario.launch(
+      InputInteractionViewTestActivity::class.java
+    )
+    Espresso.onView(ViewMatchers.withId(R.id.test_fraction_input_interaction_view))


Please prefer direct imports here and everywhere else.
onView(withId(R.id.test_fraction_input_interaction_view))

oppiabot · 2022-03-14T10:05:26Z

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks!

anandwana001 · 2022-03-14T10:38:37Z

@bhaktideshmukh

Today, it's tested through InputInteractionViewTestActivity, but these tests ought to be moved to a 
dedicated test suite for fraction input and other fraction-specific tests should be added.

After reading the issue description, what I understand is currently we use InputInteractionViewTestActivity activity to test different interactions. [FractionInputInteractionView], [NumericInputInteractionView],and [TextInputInteractionView].
As for this issue, we need to move the fraction part completely to the new test suite.

So, what we will require here is a new FractionInputInteractionViewTestActivity which does all the initialization work for the fraction part and all the current fraction tests which are using InputInteractionViewTestActivity must use the new fraction specific test activity.

Also, as part of this issue, we need to write new test cases which cover all the edge cases for fractions.
and other fraction-specific tests should be added.

Also, check this comment here - #4135 (comment)

@BenHenning Let me know if I misunderstand anything here.

anandwana001

Left nit thought and a comment above.

Update InputInteractionViewTestActivity to remove all the fraction part.
Add test result screenshots.

anandwana001 · 2022-03-14T10:40:25Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+  @DisableAccessibilityChecks
+  fun testFractionInput_withWholeNumber_hasCorrectPendingAnswer() {
+    val activityScenario = ActivityScenario.launch(
+      InputInteractionViewTestActivity::class.java


Replace with the new Fraction specific test activity.

Replace with the new Fraction specific test activity.

I tried the way you suggested, by creating FractionInputInteractionViewTestActivity to replace InputInteractionViewTestActivity but now tests are failing in FractionInputInteractionViewTest.kt file.

Specific error:--
'java.lang.RuntimeException: Unable to resolve activity for Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] cmp=org.oppia.android/.app.testing.FractionInputInteractionViewTestActivity } -- see robolectric/robolectric#4736 for details'

Please do suggest how should I proceed?

Could you share your FractionInputInteractionViewTestActivity?

Also, did you add it in the manifest file? like <activity android:name=".app.testing.InputInteractionViewTestActivity" />

I have pushed the recent changes.

anandwana001 · 2022-03-14T10:41:23Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+  qualifiers = "port-xxhdpi"
+)
+@LooperMode(LooperMode.Mode.PAUSED)
+


Suggested change

remove the empty line above.

anandwana001

Update the InputInteractionViewTestActivity as well by removing the logic of FractionInteractionViewModel as this PR is all about separating out the fraction from it.

Left few more suggestions.

Also, check for failing github actions and update the PR with the latest develop branch.

anandwana001 · 2022-03-21T02:04:02Z

app/src/main/java/org/oppia/android/app/testing/FractionInputInteractionViewTestActivity.kt

+import org.oppia.android.app.translation.AppLanguageResourceHandler
+import org.oppia.android.domain.translation.TranslationController
+import javax.inject.Inject
+


Add comment.

/** * This is a dummy activity to test input interaction views. * It contains [FractionInputInteractionView]. */

anandwana001 · 2022-03-21T02:06:00Z

app/src/main/java/org/oppia/android/app/testing/FractionInputInteractionViewTestActivity.kt

+  @Inject
+  lateinit var translationController: TranslationController
+
+  val fractionInteractionViewModel by lazy {


This class is missing onCreate function.
Take a look at the similar function in the InputInteractionViewTestActivity. Add the UI logic too.

Also, see activity_input_interaction_view_test, how we are binding the UI with the InputInteractionViewTestActivity. Now, for this PR, we need to separate out the fraction part completely in the new UI file as well.

anandwana001 · 2022-03-21T02:09:14Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+)
+@LooperMode(LooperMode.Mode.PAUSED)
+
+class FractionInputInteractionViewTest {


Run these tests on espresso and add a screenshot in the PR description showing that all the tests are passing.

anandwana001 · 2022-03-21T02:09:52Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+  qualifiers = "port-xxhdpi"
+)
+@LooperMode(LooperMode.Mode.PAUSED)
+


remove the empty line above.

anandwana001 · 2022-03-21T02:18:43Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+  @Singleton
+  @Component(
+    modules = [
+      StateFragmentTest.TestModule::class, RobolectricModule::class, PlatformParameterModule::class,


Do we need this? StateFragmentTest.TestModule

anandwana001 · 2022-03-21T02:23:14Z

app/src/main/AndroidManifest.xml

+    <activity
+      android:name=".app.testing.FractionInputInteractionViewTestActivity"
+      android:theme="@style/OppiaThemeWithoutActionBar" />


Also, keep it below the line -

<activity android:name=".app.testing.InputInteractionViewTestActivity" />

Good for readability.

anandwana001 · 2022-03-21T02:25:57Z

...c/test/java/org/oppia/android/app/customview/interaction/FractionInputInteractionViewTest.kt

+)
+@LooperMode(LooperMode.Mode.PAUSED)
+
+class FractionInputInteractionViewTest {


Suggested change

class FractionInputInteractionViewTest {

class FractionInputInteractionViewTestActivityTest {

Why do we need to change the name?

anandwana001 · 2022-03-21T02:30:28Z

app/src/main/java/org/oppia/android/app/testing/FractionInputInteractionViewTestActivity.kt

+  InteractionAnswerErrorOrAvailabilityCheckReceiver {
+
+  @Inject
+  lateinit var resourceHandler: AppLanguageResourceHandler


We had introduced inject function for this file in ActivityComponentImp, but we are not calling it.

The way we call the inject function is

(activityComponent as ActivityComponentImpl).inject(this)

without this, these @inject dependency injections will not work.

…nteration_view_test

bhaktideshmukh · 2022-03-23T16:12:40Z

@anandwana001
I did all the changes the way you suggested but while running the tests I am facing this problem:--
'API level 30 is not available'
how can I fix this?

anandwana001 · 2022-03-25T18:23:23Z

Is you PR updated with the latest develop branch? If not let's try update and re run.

…nteration_view_test

bhaktideshmukh · 2022-03-26T17:34:51Z

Is you PR updated with the latest develop branch? If not let's try update and re run.

Its still the same

bhaktideshmukh · 2022-03-27T08:00:30Z

@anandwana001 I guess I have messed this PR So I will release a new and clean PR for this issue with all your previously suggested changes.

added FractionInputInteractionViewTest.kt

6590b3e

bhaktideshmukh requested review from anandwana001 and rt4914 as code owners March 10, 2022 19:26

bhaktideshmukh assigned rt4914 and anandwana001 Mar 10, 2022

bhaktideshmukh and others added 2 commits March 11, 2022 01:01

Merge branch 'develop' into fraction_input_interation_view_test

73d719e

nit changes

bc34b37

rt4914 suggested changes Mar 14, 2022

View reviewed changes

rt4914 removed their assignment Mar 14, 2022

oppiabot bot assigned bhaktideshmukh Mar 14, 2022

anandwana001 suggested changes Mar 14, 2022

View reviewed changes

anandwana001 removed their assignment Mar 14, 2022

bhaktideshmukh assigned anandwana001 and unassigned bhaktideshmukh Mar 18, 2022

anandwana001 assigned bhaktideshmukh and unassigned anandwana001 Mar 19, 2022

bhaktideshmukh added 6 commits March 19, 2022 22:41

added FrationInputInteractionViewTestActivity

2666f9d

nit changes

5c0330e

nit changes

8ca0bc3

nit changes

4fa2e29

optimised file

6091caa

klint issues

8a44cc1

bhaktideshmukh requested a review from BenHenning as a code owner March 20, 2022 14:20

bhaktideshmukh assigned anandwana001 and unassigned bhaktideshmukh Mar 20, 2022

anandwana001 suggested changes Mar 21, 2022

View reviewed changes

anandwana001 assigned bhaktideshmukh and unassigned anandwana001 Mar 21, 2022

Merge remote-tracking branch 'upstream/develop' into fraction_input_i…

58caea7

…nteration_view_test

bhaktideshmukh assigned anandwana001 Mar 23, 2022

anandwana001 removed their assignment Mar 25, 2022

bhaktideshmukh added 3 commits March 26, 2022 22:04

added new xml file

7222d31

klint issues

8877cf1

Merge remote-tracking branch 'upstream/develop' into fraction_input_i…

cd49f97

…nteration_view_test

bhaktideshmukh assigned anandwana001 and unassigned bhaktideshmukh Mar 26, 2022

bhaktideshmukh closed this Mar 29, 2022

bhaktideshmukh deleted the fraction_input_interation_view_test branch April 6, 2022 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added FractionInputInteractionViewTest.kt #4242

Added FractionInputInteractionViewTest.kt #4242

bhaktideshmukh commented Mar 10, 2022

rt4914 left a comment

rt4914 Mar 14, 2022

rt4914 Mar 14, 2022

oppiabot bot commented Mar 14, 2022

anandwana001 commented Mar 14, 2022 •

edited

Loading

anandwana001 left a comment

anandwana001 Mar 14, 2022

bhaktideshmukh Mar 18, 2022

anandwana001 Mar 19, 2022 •

edited

Loading

bhaktideshmukh Mar 20, 2022

anandwana001 Mar 14, 2022

anandwana001 Mar 21, 2022

anandwana001 left a comment

anandwana001 Mar 21, 2022

bhaktideshmukh Mar 26, 2022

anandwana001 Mar 21, 2022

bhaktideshmukh Mar 26, 2022

anandwana001 Mar 21, 2022

anandwana001 Mar 21, 2022

anandwana001 Mar 21, 2022

anandwana001 Mar 21, 2022

anandwana001 Mar 21, 2022

bhaktideshmukh Mar 26, 2022

anandwana001 Mar 21, 2022

bhaktideshmukh Mar 26, 2022

anandwana001 Mar 21, 2022

bhaktideshmukh commented Mar 23, 2022

anandwana001 commented Mar 25, 2022

bhaktideshmukh commented Mar 26, 2022

bhaktideshmukh commented Mar 27, 2022

	class FractionInputInteractionViewTest {
	class FractionInputInteractionViewTestActivityTest {

Added FractionInputInteractionViewTest.kt #4242

Added FractionInputInteractionViewTest.kt #4242

Conversation

bhaktideshmukh commented Mar 10, 2022

Explanation

Essential Checklist

For UI-specific PRs only

rt4914 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 14, 2022

anandwana001 commented Mar 14, 2022 • edited Loading

anandwana001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandwana001 Mar 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandwana001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhaktideshmukh commented Mar 23, 2022

anandwana001 commented Mar 25, 2022

bhaktideshmukh commented Mar 26, 2022

bhaktideshmukh commented Mar 27, 2022

anandwana001 commented Mar 14, 2022 •

edited

Loading

anandwana001 Mar 19, 2022 •

edited

Loading