-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3333: Create BUILD.bazel file for domail/profile. #4074
Fix #3333: Create BUILD.bazel file for domail/profile. #4074
Conversation
Thanks for submitting this pull request! Some main reviewers |
@BenHenning All tests have passes PTAL . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno! Apologies for the late review. The PR looks good; just had 1 comment nit. PTAL.
domain/src/main/java/org/oppia/android/domain/profile/BUILD.bazel
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Henning <[email protected]>
@BenHenning PTAL changes were made |
Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishidyno. LGTM!
Fix #3333
Explanation
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: