-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3901 : [A11Y] Terminal state question player recyclerview fix #4004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect. Just one comment, pleas take a look at original PR and similar to that add screenshot of passing tests and also video of A11Y output.
done sir |
@bkaur-bkj For now, just add screenshot of two test cases that you have written. I will look why other tests are failing. Mostly they are flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Will wait for Ben's review after 6th December.
done |
Hi @bkaur-bkj, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi. FYI I've been out the last couple of weeks, so I'm working to catch up on my reviews. I might be delayed a couple of days, but I'll be reviewing this soon. Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid, thanks @bkaur-bkj! And, thanks @rt4914 for the first implementation that this is based on!
Explanation
Fixes #3901 ( its a remake of PR #3928 )
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
Espresso test results
A11Y output
WhatsApp.Video.2021-11-23.at.1.26.40.AM.mp4