-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3827: [Portuguese] Translated text overlap #3925
Conversation
@srushtirk PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@coder2699 Just merge with latest develop after which we can merge this. |
Assigning @srushtirk for code owner reviews. Thanks! |
Unassigning @srushtirk since they have already approved the PR. |
Hi @coder2699, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@rt4914 @srushtirk two tests regarding roboelectric-bazel are failing, can you help me on how to fix them |
@coder2699 I can help with that. I think you're hitting an unusual flake in StateFragmentLocalTest that's unrelated to your PR. We recently added a retry mechanism in #3969 that might at least work around this issue. Can you try merging with the latest develop & then see if CI is passing? |
@BenHenning , thanks I will try it out |
@BenHenning it worked, thanks. @rt4914, PTAL |
Unassigning @coder2699 since a re-review was requested. @coder2699, please make sure you have addressed all review comments. Thanks! |
Thanks @coder2699. Given this is approved and there are no open comment threads, going ahead & merging this. |
Explanation
Fixes #3827 : [Portuguese] Translated text overlap
Essential Checklist
Screenshot:-