Fix #3734, #669: Gate language options behind feature flag, add more patterns, and other miscellaneous alpha MR3 fixes #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of details to cover here--see the PR for the complete context.
- Add missing codeowner - Add support for configuring base branch reference - Update CI for dev/alpha AAB builds to use 'develop' since there's no origin configured by default in the workflows
This is needed to open a PR on GitHub. This commit is being made so that the PR can start off in a broken Actions state. This also initially disables most non-Bazel workflows to make workflow iteration faster and less impacting on other team members.
This introduces a new mechanism for passing lists of tests to sharded test targets in CI, and hooks it up. No actual sharding is occurring yet. This led to some simplifications in the CI workflow since the script can be more dynamic in computing the full list of targets (which also works around a previous bug with instrumentation tests being run). Java proto lite also needed to be upgraded for the scripts to be able to use it. More testing/documentation needed as this functionality continues to expand.
This simply partitions bucketed groups of targets into chunks of 10 for each run. Only 3 buckets are currently retained to test sharding in CI before introducing full support.
Fixes some caching bucket and output bugs. Also, introduces while loop & keep_going to introduce resilience against app test build failures (or just test failures in general).
Also, enable other workflows. Note that CI shouldn't fully pass yet since some documentation and testing needs to be added yet, but this is meant to be a more realistic test of the CI environment before the PR is finished.
Adds a human-readable prefix to make the shards look a bit nicer. Also, adds more fine-tuned partitioning to bucket & reduce shard counts to improve overall timing. Will need to be tested in CI.
A newly computed variable wasn't updated to be used in an earlier change.
Add docstrings for proto.
…/oppia-android into add-bundles-proguard-build-flavors
See #3757 (comment) for context.
Neither 'mv -t' nor piping to mv work on OSX so we needed to find an alternative (in this case just trying to move everything). This actually works a bit better since it's doing a per-file move rather than accommodating for files that shouldn't be moved (which isn't an issue since the destination directory is different than the one containing the AAB file).
Documentation, thorough tests, and detailed description of these changes are still needed.
This demonstrates working string selection for system-based and overwritten app languages, including necessary activity recreation & layout direction overwriting. This also includes a bunch of Dagger infra refactoring so that some app layer packages can now be modularized (including the new packages).
…o localization-part5-introduce-app-string-translations-support-and-refactor
This involves MANY broad changes to ensure consistent string retrieval (for arrays and plurals), formatting, and string transformations throughout the codebase. Some extra patterns to added to fix things that were needed, and a few issues were fixed along the way.
6 tasks
This was
linked to
issues
Sep 30, 2021
BenHenning
requested review from
anandwana001,
rt4914 and
vinitamurthi
as code owners
|
@vinitamurthi @rt4914 @anandwana001 PTAL for codeowners. |
vinitamurthi
approved these changes
Oct 5, 2021
|
Unassigning @vinitamurthi since they have already approved the PR. |
anandwana001
approved these changes
Oct 5, 2021
| @@ -90,6 +103,7 @@ class OptionsFragmentTest { | |||
|
|
|||
| @Before | |||
| fun setUp() { | |||
| TestModule.forceEnableLanguageSelectionUi = true | |||
There was a problem hiding this comment.
should we shift this initialization to each test as some require true some false?
There was a problem hiding this comment.
I sort of lean toward defaulting since it might be easy to miss in future tests. Ideally, we would use annotations to toggle features on/off, but we don't have that support yet so enabling the feature becomes a bit hidden like this.
|
Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
…answer-translations-support Conflicts: domain/BUILD.bazel
Base automatically changed from
localization-part6-introduce-content-and-answer-translations-support
to
develop
October 6, 2021 21:11
…answer-translations-support
…tions-support' into localization-part7-add-gate-for-selecting-written-language-and-add-todos
|
Merging this as-is. @anandwana001 please let me know if you feel strongly about your comment (happy to follow up with a change if needed). |
BenHenning
changed the title
BenHenning
deleted the
localization-part7-add-gate-for-selecting-written-language-and-add-todos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3734
Fix #669
Explanation
This PR:
New Regex checks
The new checks added prohibit:
These packages/components all perform or are used to perform locale-sensitive operations, and their corresponding functionality is now available in a locale-consistent & safe way using MachineLocale and DisplayLocale. The exemptions are either components that must reference these in order to provide their underlying functionality, tests where it's easier to not use OppiaLocale, or cases that didn't need to be migrated now (for these, TODOs were added with newly filed issues: #3791, #3792).
Miscellaneous fixes
Essential Checklist
For UI-specific PRs only
Screenshots (language options now missing):
Portrait:
Landscape:
Note: tablet screenshots not included since this UI change a trivial removal of behavior. Similarly, RTL & Talkback behaviors aren't included since this is just removing an item from the options menu.
Espresso results: OptionsFragmentTest is passing: