-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3803: Bazel/Gradle Support on Kitkat [BLOCKED on #3804] #3740
Conversation
app/src/main/java/org/oppia/android/app/application/ApplicationInjectorKitkat.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/application/ApplicationInjectorProviderKitkat.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/application/ApplicationKitkatComponent.kt
Outdated
Show resolved
Hide resolved
...main/java/org/oppia/android/domain/platformparameter/syncup/PlatformParameterSyncUpWorker.kt
Show resolved
Hide resolved
@anandwana001 this isn't introducing bundle support yet since it isn't using android_application--can you try out that target first to see if it works before separating out data module? |
@anandwana001 now that #3750 exists please update this to be branched off of that & update the approach to change the flavors defined in build_flavors.bzl, instead. |
… kitkat_bazel_support
The current implementation in this PR works when built and install using gradle. Getting following error with Bazel.
|
@anandwana001 do we have an issue tracking the latest KitKat issue (the SVG issue)? Also, can you please update the PR title & description to more correctly describe what this PR is actually doing? We now have AAB support checked in, so the current title is no longer correct. |
Hi @anandwana001, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue. |
Hi @anandwana001, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue. |
closing this as this is handled in other pr. |
Explanation
Fix #3803
APK supports on Kitkat when built using Gradle.
APK is building using Bazel, but crash when run on Kitkat version with the following errors:
The permission issue can be solved using adding permission to manifest
, but need to figure out the exact reason why KitKat needs this permission.
Checklist