Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2403: Resolve ktlint max line in player test package #3260

Merged
merged 16 commits into from
Jun 3, 2021
Merged

Fix #2403: Resolve ktlint max line in player test package #3260

Changes from 11 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
19c2648
Removed ktlint max line in player test package
pravesh00 May 28, 2021
2fd2aa3
Remove ktlint max line errors
pravesh00 May 28, 2021
c427f85
Max line ktlint in player test package
pravesh00 May 28, 2021
724c42b
Remove ktlint max line errors
pravesh00 May 28, 2021
f9b0c52
Removed more ktlint max line errors
pravesh00 May 28, 2021
5a8b054
run config file reverted
pravesh00 May 28, 2021
9292ecc
Review changes made
pravesh00 May 28, 2021
cc6b6ae
Remove ktlint max line errors from player test package
pravesh00 May 28, 2021
008d39e
Remove ktlint max line errors from player test package
pravesh00 May 28, 2021
8786577
Maxline error in player test package
pravesh00 May 31, 2021
8eca7ac
Review Changes
pravesh00 May 31, 2021
a5f242a
Merge remote-tracking branch 'upstream/develop' into player-test-pack…
pravesh00 Jun 2, 2021
274b0f1
Review Changes Made
pravesh00 Jun 2, 2021
08305ae
Review Changes
pravesh00 Jun 2, 2021
263b20e
Review Changes
pravesh00 Jun 2, 2021
c614b16
Review Changes
pravesh00 Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithNoVoiceover_openPrototypeExploration_configurationChange_checkAudioButtonIsHidden() { // ktlint-disable max-line-length
fun testAudioWithNoVoiceover_prototypeExploration_configChange_checkAudioButtonIsHidden() {
launch<ExplorationActivity>(
createExplorationActivityIntent(
internalProfileId,
Expand Down Expand Up @@ -429,9 +428,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithCellular_openRatioExploration_clickAudioIcon_changeConfiguration_checkOpensCellularAudioDialog() { // ktlint-disable max-line-length
fun testAudioCell_ratioExploration_audioIcon_configChange_opensCellularAudioDialog() {
setupAudio()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand All @@ -453,9 +451,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithCellular_openRatioExploration_clickAudioIcon_clickNegative_checkAudioFragmentIsHidden() { // ktlint-disable max-line-length
fun testAudioCell_ratioExploration_audioIcon_clickNegative_audioFragmentIsHidden() {
setupAudio()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -486,9 +483,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithCellular_openRatioExploration_clickAudioIcon_clickPositive_checkAudioFragmentIsVisible() { // ktlint-disable max-line-length
fun testAudioCell_ratioExp_audioIcon_clickPositive_checkAudioFragmentIsVisible() {
setupAudio()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -528,9 +524,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithCellular_openRatioExploration_clickCheckboxAndNegative_clickAudioIcon_checkAudioFragmentIsHiddenAndDialogIsNotDisplayed() { // ktlint-disable max-line-length
fun testAudioCell_ratioExp_check_negative_audioIcon_audioFragHiddenDialogNotDisplay() {
setupAudio()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -565,9 +560,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithCellular_openRatioExploration_clickCheckboxAndPositive_clickAudioIconTwice_checkAudioFragmentIsVisibleAndDialogIsNotDisplayed() { // ktlint-disable max-line-length
fun testAudioCell_ratioExp_checkPositive_audioIconTwice_audioFragVisDialogNotDisplay() {
setupAudio()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -603,11 +597,10 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
// TODO(#89): The ExplorationActivity takes time to finish. This test case is failing currently.
@Test
@Ignore("The ExplorationActivity takes time to finish, needs to fixed in #89.")
fun testAudioWithWifi_openRatioExploration_clickAudioIcon_checkAudioFragmentHasDefaultLanguageAndAutoPlays() { // ktlint-disable max-line-length
fun testAudioWifi_ratioExp_audioIcon_audioFragHasDefaultLangAndAutoPlays() {
getApplicationDependencies(RATIOS_EXPLORATION_ID_0)
networkConnectionUtil.setCurrentConnectionStatus(NetworkConnectionUtil.ConnectionStatus.LOCAL)
launch<ExplorationActivity>(
Expand Down Expand Up @@ -639,9 +632,8 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
@Test
fun testAudioWithWifi_openFractionsExploration_changeLanguage_clickNext_checkLanguageIsHinglish() { // ktlint-disable max-line-length
fun testAudioWifi_fractionsExp_changeLang_next_langIsHinglish() {
setUpAudioForFractionLesson()
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -694,12 +686,10 @@ class ExplorationActivityTest {
explorationDataController.stopPlayingExploration()
}

// TODO (#1855): Resolve ktlint max line in app module test
// TODO(#89): The ExplorationActivity takes time to finish. This test case is failing currently.
@Test
@Ignore("The ExplorationActivity takes time to finish, needs to fixed in #89.")
fun testAudioWithWifi_openRatioExploration_continueToInteraction_clickAudioButton_submitAnswer_checkFeedbackAudioPlays() { // ktlint-disable max-line-length
getApplicationDependencies(RATIOS_EXPLORATION_ID_0)
fun testAudioWifi_ratioExp_continueInteraction_audioButton_submitAns_feedbackAudioPlays() {
networkConnectionUtil.setCurrentConnectionStatus(NetworkConnectionUtil.ConnectionStatus.LOCAL)
launch<ExplorationActivity>(
createExplorationActivityIntent(
Expand Down Expand Up @@ -775,10 +765,9 @@ class ExplorationActivityTest {
}
}

// TODO (#1855): Resolve ktlint max line in app module test
// TODO(#89): Check this test case too. It works in pair with below test case.
@Test
fun testExplorationActivity_onBackPressed_showsStopExplorationDialog_clickCancel_dismissesDialog() { // ktlint-disable max-line-length
fun testExpActivity_onBackPressed_showsStopExpDialog_cancel_dismissesDialog() {
explorationActivityTestRule.launchActivity(
createExplorationActivityIntent(
internalProfileId,
Expand All @@ -793,11 +782,10 @@ class ExplorationActivityTest {
assertThat(explorationActivityTestRule.activity.isFinishing).isFalse()
}

// TODO (#1855): Resolve ktlint max line in app module test
// TODO(#89): The ExplorationActivity takes time to finish. This test case is failing currently.
@Test
@Ignore("The ExplorationActivity takes time to finish, needs to fixed in #89.")
fun testExplorationActivity_onBackPressed_showsStopExplorationDialog_clickLeave_closesExplorationActivity() { // ktlint-disable max-line-length
fun testExpActivity_onBack_showsStopExpDialog_leave_closesExpActivity() {
explorationActivityTestRule.launchActivity(
createExplorationActivityIntent(
internalProfileId,
Expand Down