Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #632: StorySummaryAdapter to use BindableAdapter #3218

Merged
merged 3 commits into from
May 24, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented May 21, 2021

Explanation

Fixes a part of #632

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested a review from rt4914 as a code owner May 21, 2021 13:16
@anandwana001 anandwana001 self-assigned this May 21, 2021
@anandwana001 anandwana001 marked this pull request as draft May 21, 2021 13:16
@anandwana001
Copy link
Contributor Author

@yashraj-01 Adding you as a review for this PR, as your GSoC project is going to have a lot around the app module, so I was thinking it might be helpful if you review this PR. It's voluntary thing.

@anandwana001 anandwana001 marked this pull request as ready for review May 21, 2021 14:04
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandwana001 Left a comment, PTAL

@oppiabot
Copy link

oppiabot bot commented May 22, 2021

Unassigning @FareesHussain since the review is done.

Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the BUILD.bazel change.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Suggestion nit changes.

@rt4914 rt4914 removed their assignment May 23, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@anandwana001 anandwana001 merged commit 05bf59a into oppia:develop May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants