-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #632: StorySummaryAdapter to use BindableAdapter #3218
Fix part of #632: StorySummaryAdapter to use BindableAdapter #3218
Conversation
@yashraj-01 Adding you as a review for this PR, as your GSoC project is going to have a lot around the app module, so I was thinking it might be helpful if you review this PR. It's voluntary thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anandwana001 Left a comment, PTAL
app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragmentPresenter.kt
Show resolved
Hide resolved
Unassigning @FareesHussain since the review is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the BUILD.bazel change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Suggestion nit changes.
app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragmentPresenter.kt
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fixes a part of #632
Checklist