Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3178: Changed InputSelection background #3184

Merged
merged 1 commit into from
May 13, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 11, 2021

Explanation

Fix #3178: Changed InputSelection background

This implementation passes the A11y Scanner too.

Before vs. After


Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 May 11, 2021 16:08
@rt4914 rt4914 assigned rt4914 and anandwana001 and unassigned rt4914 May 11, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@rt4914 just for reference could you please add a screenshot showing the error text is now aligned to the input box?

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 13, 2021
@oppiabot oppiabot bot added the PR: LGTM label May 13, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented May 13, 2021

LGTM,

@rt4914 just for reference could you please add a screenshot showing the error text is now aligned to the input box?

@anandwana001 Added in description.

@rt4914 rt4914 merged commit 20b0c2e into develop May 13, 2021
@rt4914 rt4914 deleted the input-interaction-shadow branch May 13, 2021 06:59
@anandwana001
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blue background mis-alignment in Input Interactions
2 participants