-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3089: Removed unnecessary context initialization in RevisionCardFragmentTest #3124
Fix #3089: Removed unnecessary context initialization in RevisionCardFragmentTest #3124
Conversation
@Pranav-Bobde Can you also add a screenshot of test results on robolectric? |
@Pranav-Bobde Thanks for the second PR. |
@prayutsu I don't it's required as the robolectric tests are running on GitHub actions. We always need espresso, because, it's not there in the actions. |
@anandwana001 |
Re running checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @Pranav-Bobde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fixes #3089: In RevisionCardFragmentTest, in function setUp() there's no need for initializing context we are already injecting it through dagger.
Checklist