Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3089: Removed unnecessary context initialization in RevisionCardFragmentTest #3124

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix #3089: Removed unnecessary context initialization in RevisionCardFragmentTest #3124

merged 1 commit into from
May 4, 2021

Conversation

Pranav-Bobde
Copy link
Contributor

@Pranav-Bobde Pranav-Bobde commented Apr 27, 2021

RevisionCardFragmentTests Passed

Explanation

Fixes #3089: In RevisionCardFragmentTest, in function setUp() there's no need for initializing context we are already injecting it through dagger.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Pranav-Bobde Pranav-Bobde requested a review from rt4914 as a code owner April 27, 2021 12:11
@rt4914 rt4914 self-assigned this Apr 28, 2021
@prayutsu
Copy link
Contributor

@Pranav-Bobde Can you also add a screenshot of test results on robolectric?

@prayutsu prayutsu assigned Pranav-Bobde and unassigned prayutsu Apr 29, 2021
@anandwana001
Copy link
Contributor

@Pranav-Bobde Thanks for the second PR.
Please follow the checklist given in the PR description.

@anandwana001
Copy link
Contributor

@Pranav-Bobde Can you also add a screenshot of test results on robolectric?

@prayutsu I don't it's required as the robolectric tests are running on GitHub actions. We always need espresso, because, it's not there in the actions.

@Pranav-Bobde Pranav-Bobde changed the title removed context initialization in RevisionCardFragmentTest Fix #3089: Removed unnecessary context initialization in RevisionCardFragmentTest Apr 29, 2021
@Pranav-Bobde
Copy link
Contributor Author

@anandwana001
so what do i need to do now to solve that last error?
i have shared screenshot of espresso (instrumented test only no?)

@anandwana001
Copy link
Contributor

Re running checks

@anandwana001 anandwana001 assigned rt4914 and unassigned Pranav-Bobde May 3, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Pranav-Bobde

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit b54ab97 into oppia:develop May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove context initialization in RevisionCardFragmentTest
5 participants