Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2811: Added label to OngoingTopicListActivity #3002

Merged
merged 6 commits into from
Mar 31, 2021
Merged

Fix #2811: Added label to OngoingTopicListActivity #3002

merged 6 commits into from
Mar 31, 2021

Conversation

jkugsiya
Copy link
Contributor

Explanation

Fixes #2811 : Added label to OngoingTopicListActivity and added checks

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

prayutsu
prayutsu suggested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @jkugsiya. Left some comments.

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/ongoingtopiclist/OngoingTopicListActivityTest.kt Show resolved Hide resolved
rt4914
rt4914 suggested changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkugsiya Suggested changes.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@FareesHussain
Copy link
Contributor

@jkugsiya any updates on this?

@jkugsiya
Copy link
Contributor Author

@jkugsiya any updates on this?

Yes, working on it.

@jkugsiya
Copy link
Contributor Author

@rt4914 Please review, I've made the requested changes.

@rt4914 rt4914 assigned rt4914 and prayutsu and unassigned jkugsiya Mar 30, 2021
rt4914
rt4914 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Mar 30, 2021
prayutsu
prayutsu approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jkugsiya!

@prayutsu prayutsu removed their assignment Mar 30, 2021
BenHenning
BenHenning approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkugsiya! LGTM for codeowners.

@BenHenning BenHenning merged commit ae123f2 into oppia:develop Mar 31, 2021
@jkugsiya jkugsiya deleted the A11y-OngoingTopicList branch April 8, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayutsu prayutsu prayutsu approved these changes

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for OngoingTopicListActivity
5 participants
@jkugsiya @FareesHussain @rt4914 @BenHenning @prayutsu